Skip to content

Add parameter to control public sharing option #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 1, 2019
Merged

Add parameter to control public sharing option #75

merged 1 commit into from
Feb 1, 2019

Conversation

davideschiera
Copy link
Contributor

Add public optional parameter to define whether a new dashboard should be publicly shared or not. Affected functions:

  • create_dashboard_from_template
  • create_dashboard_from_view
  • create_dashboard_from_dashboard
  • create_dashboard_from_file

@davideschiera davideschiera self-assigned this Feb 1, 2019
@davideschiera davideschiera merged commit ecc99dd into master Feb 1, 2019
@davideschiera davideschiera deleted the OSSPROJ-6-public-dashboard branch February 1, 2019 01:41
figarocorso
figarocorso reviewed Feb 11, 2019
View reviewed changes
Copy link
Contributor

@figarocorso figarocorso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sorry for being late

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@figarocorso figarocorso figarocorso left review comments

Assignees

@davideschiera davideschiera

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davideschiera @figarocorso