feat(event-bridge): api destinations (SSPROD-53939) #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matteopasa
force-pushed
the
pasa/event-bridge/api-dest
branch
from
530c57e to
ae20f9c
Compare
* first draft of api dest tf * update tfs after testing * update readme * use provider version * use event-bridge folder * rename * add cloudwatch permissions and newlines * one locals block
matteopasa
force-pushed
the
pasa/event-bridge/api-dest
branch
from
6bf95e0 to
3fb73e7
Compare
lorenzo-merici
approved these changes
Apr 15, 2025
ravinadhruve10
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes significant updates to the AWS Event Bridge integration module to enhance its functionality and improve security. The main changes involve updating the module to use EventBridge API Destinations, adding new IAM roles and policies, and updating documentation to reflect these changes.
Enhancements to EventBridge Integration:
README.mdto describe the use of EventBridge API Destinations and the new resources created, includingEventBridge API DestinationandEventBridge Connection.Documentation Updates:
README.mdto reflect the changes in the module, including new resource descriptions and updated requirements and providers. [1] [2]api_dest_rate_limitto control the rate limit for API Destinations.Code Refactoring:
main.tfto include new data sources and local variables for the EventBridge API Destination configuration. [1] [2]Deprecation Notices:
org_unitsinput as deprecated, advising users to migrate toinclude_ouids.These changes enhance the module's capabilities for log ingestion and threat detection, making it more robust and secure.