Skip to content

feat(cloudlogs): improve support for empty kms key #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2025
Merged

feat(cloudlogs): improve support for empty kms key #80

merged 1 commit into from
Jul 31, 2025

Conversation

lorenzo-merici
Copy link
Collaborator

  • Updated kms_account_id and need_kms_policy locals to handle empty string.
  • Added var.kms_key_arn != "" check in KMS IAM policy for_each.

@lorenzo-merici lorenzo-merici requested a review from a team as a code owner July 31, 2025 08:33
@lorenzo-merici lorenzo-merici force-pushed the feat/cloudlogs/support_empty_kms branch from fc7a3b7 to bd01c53 Compare July 31, 2025 08:34
@lorenzo-merici lorenzo-merici merged commit c2cdd1b into main Jul 31, 2025
1 check passed
@lorenzo-merici lorenzo-merici deleted the feat/cloudlogs/support_empty_kms branch July 31, 2025 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matteopasa matteopasa matteopasa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lorenzo-merici @matteopasa