Skip to content

Conversation

bugadani
Copy link
Contributor

@bugadani bugadani commented Jan 6, 2025

No description provided.

@bugadani bugadani marked this pull request as ready for review January 6, 2025 11:01
@ivmarkov
Copy link
Collaborator

ivmarkov commented Jan 6, 2025

Perhaps remove embassy-time-queue-driver from the list of deps?

There are other dragons down the road though. Have to check if the new driver supports the API we need. I abuse the driver API for stuff which is not exposed via embassy-time :-(

@bugadani
Copy link
Contributor Author

bugadani commented Jan 6, 2025

don't worry about it, I'll handle anything needed, I just need CI to tell me I'm wrong

@ivmarkov
Copy link
Collaborator

ivmarkov commented Jan 6, 2025

don't worry about it, I'll handle anything needed, I just need CI to tell me I'm wrong

Thanks!
You might have difficulties figuring out why I use the driver directly (I myself am having difficulties trying to remember all hacks I had to do so as to support the async-io Timer API on top of embassy-time.)

Ping me here or on Matrix if we need to discuss.

@bugadani bugadani force-pushed the embassy-time branch 4 times, most recently from aeefcc2 to 4072e35 Compare January 6, 2025 11:47
@ivmarkov ivmarkov merged commit 12f13cb into sysgrok:master Jan 6, 2025
2 checks passed
@bugadani bugadani deleted the embassy-time branch January 6, 2025 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants