Skip to content

defmt #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 11, 2025
Merged

defmt #68

merged 1 commit into from
Apr 11, 2025

Conversation

ivmarkov
Copy link
Collaborator

No description provided.

@ivmarkov ivmarkov force-pushed the defmt branch 9 times, most recently from a4f416f to 4291f73 Compare April 11, 2025 07:11
@ivmarkov ivmarkov marked this pull request as ready for review April 11, 2025 07:27
@ivmarkov ivmarkov merged commit 1a686a9 into master Apr 11, 2025
2 checks passed
AnthonyGrondin
AnthonyGrondin reviewed Apr 11, 2025
View reviewed changes
Copy link
Contributor

@AnthonyGrondin AnthonyGrondin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work. I just came around to needing this feature.

Did you forget to implement defmt::Format for edge_http::io::Error<E>? I'm getting errors trying to log edge_http::io::Error<TcpError>

AnthonyGrondin
AnthonyGrondin reviewed Apr 12, 2025
View reviewed changes
AnthonyGrondin
AnthonyGrondin reviewed Apr 12, 2025
View reviewed changes
Copy link
Contributor

@AnthonyGrondin AnthonyGrondin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few errors that happen when building with DEFMT_LOG= which enables defmt. These weren't present when I didn't enable it.

There's a few I didn't mark, and are mostly related to those described in this review, but in different places.

@ivmarkov
Copy link
Collaborator Author

@AnthonyGrondin Now it should be OK.
But check my comments for the places where we use display2format and debug2format now.

@ivmarkov ivmarkov deleted the defmt branch August 14, 2025 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@AnthonyGrondin AnthonyGrondin AnthonyGrondin left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivmarkov @AnthonyGrondin