Skip to content

Fix error in make valgrind #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

WangHanChi
Copy link
Contributor

Because "chmod u+x $(patched_file)" this command need root prtmission,
so I add "sudo" in this command.

Because "chmod u+x $(patched_file)" this command need root prtmission,
so I add "sudo" in this command.
@jserv
Copy link
Contributor

jserv commented Mar 2, 2023

Because "chmod u+x $(patched_file)" this command need root prtmission, so I add "sudo" in this command.

You should instead present rational explanation behind why superuser permission is required.

@WangHanChi
Copy link
Contributor Author

In my observation, I found that if I use "sudo make valgrind", it will cause the permissions in some files become root.
And there will be a error when make or make clean in next time.
In short, I misused the "sudo" and made this mistake.
Therefore, this pull request is invalid.

@WangHanChi WangHanChi closed this Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants