Avoid using generic subjects #198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generic subjects like "Complete," "Finish," or "Done" are problematic because they: 1. Lack specificity, making it unclear what was actually changed. 2. Are ambiguous and provide poor historical context. 3. Assume finality, whereas in engineering practice, designs are always subject to further refinement or improvement. Change-Id: I8c27d25c9844d70618ce166579bee2cd3ef7c93d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generic subjects like "Complete," "Finish," or "Done" are problematic because they:
Change-Id: I8c27d25c9844d70618ce166579bee2cd3ef7c93d