Refine commit hook #214
Merged
Refine commit hook #214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I585731a7b187785277627198aea814bf055529c7
Auto-generated trailers (e.g. 'Signed-off-by') should be excluded from validation. This commit builds proper regular expressions and removes predefined 'Change-Id:' detection accordingly. Change-Id: Ide1ac959fe41f0f019db92c7ae6e682fa1d17615
lumynou5
reviewed
Mar 2, 2025
| # Predefined trailer keys. | ||
| trailers=( | ||
| 'CC' 'Change-Id' | ||
| 'Bug' 'Close' 'Closes' |
There was a problem hiding this comment.
Having only one of Close and Closes seems better for consistency.
Besides, do colon-seperated key-value pairs work? The GitHub document doesn't mention this and the examples are all seperated by spaces.
There was a problem hiding this comment.
do colon-seperated key-value pairs work? The GitHub document doesn't mention this and the examples are all seperated by spaces.
Feel free to submit pull request(s) to refine git hooks.
Dennis40816
added a commit
to Dennis40816/lab0-c
that referenced
this pull request
Mar 3, 2025
PR sysprog21#209's functionality was broken due to changes introduced in PR sysprog21#214, specifically in commit '4a8d8b5', where some occurrences of 'COMMIT_MSG_LINES' were replaced with 'commit_msg_lines' without updating all relevant functions. This commit fixes the issue by replacing all instances of 'COMMIT_MSG_LINES' with 'commit_msg_lines', ensuring consistency and restoring the functionality introduced in PR sysprog21#209. Change-Id: I0c93617be83c5f24b1e17678566883c0481ddc48
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.