Skip to content

Conversation

ibat10clw
Copy link
Contributor

Replace hard-coded value 256 with BUCKET_SIZE macro for better readability and maintainability

Change-Id: I4b123b7267dcb9beac8d791fd1e7cb9b75a6b446

Copy link
Contributor

@jserv jserv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Properly tweak the layout of messages. That is,

Replace hard-coded value with BUCKET_SIZE macro for better readability
and maintainability.

@ibat10clw
Copy link
Contributor Author

I have updated the commit message as requested. Please review the changes. Thanks!

@jserv
Copy link
Contributor

jserv commented Mar 10, 2025

I have updated the commit message as requested.

You can simply write as following:

Replace hard-coded value with BUCKET_SIZE macro for better readability.

You don't have to leave message for requesting reviews. Check this: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/requesting-a-pull-request-review

Replace hard-coded value with BUCKET_SIZE macro for better readability.

Change-Id: I4b123b7267dcb9beac8d791fd1e7cb9b75a6b446
@jserv jserv merged commit edd54e1 into sysprog21:master Mar 10, 2025
@jserv
Copy link
Contributor

jserv commented Mar 10, 2025

Thank @ibat10clw for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants