Ensure all trailers remain after Change-Id #251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jserv
reviewed
Mar 10, 2025
jserv
reviewed
Mar 10, 2025
| done | ||
| keys+=("$key") | ||
| done < <(git config --get-regexp 'trailer.*.key') | ||
| TRAILERS_BY_REGEX="^($(IFS='|'; echo "${trailers_by[*]}")):" |
There was a problem hiding this comment.
Add comments to make list for the possible trailers.
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
charliechiou
force-pushed
the
fix-git-hook
branch
from
952a91d to
ccd5821
Compare
jserv
requested changes
Mar 10, 2025
charliechiou
force-pushed
the
fix-git-hook
branch
from
ccd5821 to
d5508e0
Compare
jserv
requested changes
Mar 10, 2025
charliechiou
force-pushed
the
fix-git-hook
branch
from
d5508e0 to
bfd168f
Compare
Previously, only "Co-authored-by" appeared before Chang-Id, while other trailers (e.g., Signed-off-by, Reviewed-by) were placed after it. This change ensures that all trailers consistently appear before Change-Id. Co-authored-by: EricccTaiwan <yphbchou0911@gmail.com> Change-Id: Ia86b357fa5dcb44ea172000f296f70a364723080
charliechiou
force-pushed
the
fix-git-hook
branch
from
bfd168f to
d83b210
Compare
|
Thank @charliechiou for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, only "Co-authored-by" appeared before Chang-Id, while other trailers (e.g., Signed-off-by, Reviewed-by) were placed after it. This change ensures that all trailers consistently appear before Change-Id.
Change-Id: I12c391c4ced8e200f26f53c34fc0e877b7af8561