Fix reversed output and optimize base-10 conversion #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The __str_base10() function mistakenly reversed the digits again, causing the final string to be printed backward. This patch corrects the digit copy order in __str_base10() and adds a final string reversal in itoa() to restore the correct output order for base 10 conversions. Fixes: b3e756c ("Optimize base-10 conversion for RV32I libc")
Eliminate the temporary tmp[] buffer in __str_base10() by writing digits directly into the output buffer. This avoids an extra memory copy and improves efficiency while keeping the logic simple. The maximum digit count comment is also removed as it is no longer relevant.
|
Thank @visitorckw for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix incorrect decimal output and improves the efficiency of base-10
conversion routines used by itoa() and vsprintf(). The bug was caused
by an unnecessary reversal of digits in __str_base10(), resulting in
reversed output. This is corrected by writing digits in the correct
order and applying a single final reversal in itoa() for signed
numbers. Additionally, the implementation is simplified by removing the
temporary buffer in __str_base10() and writing digits directly into the
output buffer, reducing memory operations and improving performance.