Support java string and concatenation #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jserv
reviewed
Aug 31, 2022
jserv
reviewed
Aug 31, 2022
classfile.h
Outdated
| u4 attribute_length; | ||
| u2 num_bootstrap_methods; | ||
| bootstrap_methods_t *bootstrap_methods; | ||
| } bootstrapMethods_attribute_t; |
There was a problem hiding this comment.
bootstrapMethods_attribute_t looks a bit longer. How about bootmethods_attr_t?
jserv
reviewed
Aug 31, 2022
Implement `invokedynamic` opcode that can run bootstrap methods in order to do string concatenation, and modify `ldc` so that it can create new string. Every string will be created by `create_string` function, which can place each string into heap so that strings can be released correctly. Note that current implmentmentation of `invokedynamic` only supports `makeConcatWithConstants`, so callsite and lambda aren't supported. Add a new test script: "Strings.java"
|
Great work! This pull request makes it more practical as a JVM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
invokedynamicopcode that can run bootstrap methods in order to do string concatenation, and modifyldcso that it can create new string.Every string will be created by
create_stringfunction, which can place each string into heap so that strings can be released correctly.Note that current implmentmentation of
invokedynamiconly supportsmakeConcatWithConstants, so callsite and lambda aren't supported.