Refine the SDL-oriented system calls declaration #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please read Unsigned Integers Are Dangerous. We have to validate the dimension of SDL window and the corresponding ranges. |
jserv
reviewed
Dec 30, 2022
alanjian85
force-pushed
the
master
branch
2 times, most recently
from
43a3bd9 to
79827be
Compare
jserv
reviewed
Dec 30, 2022
jserv
reviewed
Dec 30, 2022
Replace the type of some system call parameters with signed int and size_t, and handle handle them properly in the emulator. Change the name of the parameter "screen" of the "draw_frame" system call to "base" for the sake of consistency with the "setup_queue" system call.
vestata
pushed a commit
to vestata/rv32emu
that referenced
this pull request
Jan 24, 2025
Refine the SDL-oriented system calls declaration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the type of all int parameters of system calls with unsigned, because they are usually treated as uint32_t internally by the emulator. And change the name of the parameter "screen" of the "draw_frame" system call to "base" for the sake of consistency with the "setup_queue" system call.