Support RISC-V Compressed Instructions #11
Conversation
|
You should rebase the latest |
There was a problem hiding this comment.
Rework your git commits! See https://blog.yorkxin.org/posts/git-rebase.html
|
Files statistics.[ch] should appear in another pull request! |
|
@jserv , should these commits be squashed into a single one? |
It depends on the scenario. In this case, at least two git commits should be landed:
In addition, @xiaohan484 should list @ccs100203 as the co-author. See https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors |
xiaohan484
force-pushed
the
master
branch
4 times, most recently
from
4cec54c to
730f790
Compare
|
@jserv, commits are squashed into 2 parts. @xiaohan484 will polish commit messages later. |
xiaohan484
force-pushed
the
master
branch
4 times, most recently
from
9623615 to
706c3af
Compare
|
@xiaohan484 , I think "co-author" should be mentioned in commit body, not commit header. |
xiaohan484
force-pushed
the
master
branch
2 times, most recently
from
8fc854b to
643cbc7
Compare
|
In git commit messages, you should append the statement "No RV32C.F support." |
|
xiaohan484
force-pushed
the
master
branch
2 times, most recently
from
9ed8ea4 to
a7cee22
Compare
|
I rebase the commit but remain the latest commit.The code "inst_len" parts are in "struct riscv_t", I move "enum" part to the above of "struct riscv_t" and indent the enum parts. |
No, you should use
Of course, you have to ensure each git commit message meaningful and informative. |
xiaohan484
force-pushed
the
master
branch
2 times, most recently
from
bf73981 to
9a71fdd
Compare
There has a variable inst_len(2 or 4) to calculate the next PC, RV32C related exception handler and all RV32C implementation exclude RV32C.F. Note: c.ebreak does'nt pass compliance test. Co-authored-by: ccs100203 <ccs100203@gmail.com> Co-authored-by: Uduru0522 <kurasiki.homura@gmail.com>
This work use TABLE_TYPE_RVC type for RV32C's opcode handler type to dispatch function.All RV32C related function rename to op_c* to cooperate with computed-goto for standard uncompressed function.
|
Thank @xiaohan484 for contributing! Let's move forward to riscv-arch-test compliance. |
Support RISC-V Compressed Instructions
This work is based on sammer1107 and ccs100203. The RV32C is integrated with COMPUTE_GOTO and still don't support RV32C.F instruction. The C-extension compliance test was passed.