Fix Wrong MSTATUS_MXR_SHIFT #610
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
jserv
requested changes
Sep 21, 2025
snnbyyds
force-pushed
the
fix-mstatus-mxr
branch
from
5a136be to
576f105
Compare
Updated |
|
Follow How to Write a Git Commit Message: |
MSTATUS_MXR_SHIFT was incorrectly defined as 18, duplicating the SUM shift value, and is corrected to 19 to match the RISC-V specification. Signed-off-by: snnbyyds <snnbyyds@gmail.com>
snnbyyds
force-pushed
the
fix-mstatus-mxr
branch
from
576f105 to
5ae66cc
Compare
|
Updated as per your suggestion. |
|
Thank @snnbyyds for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Corrects the MSTATUS_MXR_SHIFT constant in riscv.h from 18 to 19 to match the RISC-V spec. This fixes MXR bit handling and avoids aliasing with the SUM bit.