CI: Add curl-or-wget wrapper and shared download functions #612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jserv
force-pushed
the
download-script
branch
from
f9c2619 to
91cd99c
Compare
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
jserv
changed the title
jserv
force-pushed
the
download-script
branch
2 times, most recently
from
477ad03 to
d9c5026
Compare
jserv
changed the title
This adds a universal download compatibility commands that work with curl or wget. The download tool check was failing scripts that source common.sh but don't use download functions (like riscv-tests.sh). This changes to only check for curl/wget when a download function is actually called. This prevents unnecessary failures in scripts that source common.sh for other utilities like PARALLEL or check_platform().
jserv
force-pushed
the
download-script
branch
from
d9c5026 to
4a11687
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a universal download compatibility layer that works with curl or wget, along with download utility functions to .ci/common.sh script.
Summary by cubic
Introduce a curl/wget compatibility layer and shared download helpers in .ci/common.sh to make CI downloads robust across environments and reduce duplicated shell code.
New Features
Refactors