Fix -Werror=maybe-uninitialized warning #616
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GCC with AddressSanitizer reports that pathp in map_insert() may be used uninitialized: src/map.c:593:15: error: pathp may be used uninitialized 593 | for (pathp--; (uintptr_t) pathp >= (uintptr_t) path; pathp--) While the program logic ensures pathp is always initialized through rb_insert_unique() before use, static analysis cannot prove this due to the pointer-to-pointer assignment pattern. Initialize to NULL to satisfy the compiler and improve defensive programming.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GCC with AddressSanitizer reports that pathp in map_insert() may be used uninitialized:
While the program logic ensures pathp is always initialized through rb_insert_unique() before use, static analysis cannot prove this due to the pointer-to-pointer assignment pattern. Initialize to NULL to satisfy the compiler and improve defensive programming.
Summary by cubic
Initialize pathp to NULL in map_insert() to silence GCC -Werror=maybe-uninitialized under AddressSanitizer and prevent build failures. No functional change; rb_insert_unique() still sets pathp before use, this just makes the compiler happy.