Fix red-black tree's implementation #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even though the commit ff46dad has shortened the map code, I found that it may be incorrect because the second parameter passed to the function "rb_set_parent" on line 537 is "*indirect", which was just assigned to the value of new node in the previous statement. I added a variable "parent" to store the previous value of "indirect" before any changes were made and set it as the parent of "new_node" as the old code intended.
|
Looks good to me. |
vestata
pushed a commit
to vestata/rv32emu
that referenced
this pull request
Jan 24, 2025
Even though the commit 6161d53 has shortened the map code, I found that it may be incorrect because the second parameter passed to the function "rb_set_parent" on line 537 is "*indirect", which was just assigned to the value of new node in the previous statement. I added a variable "parent" to store the previous value of "indirect" before any changes were made and set it as the parent of "new_node" as the old code intended.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though the commit ff46dad has shortened the map code, I found that it may be incorrect because the second parameter passed to the function
rb_set_parenton line 537 is*indirect, which was just assigned to the value of new node in the previous statement. I added a variableparentto store the previous value ofindirectbefore any changes were made and set it as the parent ofnew_nodeas the old code intended.