Improve memory safety via sanitizers #251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add infrastructure for building and testing shecc with AddressSanitizer and UndefinedBehaviorSanitizer to detect memory safety issues. - Add 'sanitizer' target that builds stage 0 with sanitizers enabled - Add 'check-sanitizer' target for running tests with sanitizer build - Use -fsanitize=address -fsanitize=undefined flags - Add -fno-omit-frame-pointer for better stack traces
The arena allocator was using a hardcoded PTR_SIZE (4 bytes) for memory alignment, which caused misalignment issues on 64-bit host systems where pointers are 8 bytes. This led to UndefinedBehaviorSanitizer errors.
Changed all structure allocations to use arena_calloc instead of arena_alloc to ensure zero-initialization and eliminate undefined behavior from accessing uninitialized memory. This fixes sanitizer errors related to: - block_t, var_t, basic_block_t structures in parsing - insn_t structures in SSA passes - ph2_ir_t structures in register allocation - constant_t, alias_t, macro_t structures in symbol management
Fixed a parser crash that occurred when encountering pointer dereference assignment statements like '*ap = 0;'. The issue was that the parser was trying to find a function named '*ap' before properly handling the pointer dereference syntax. The fix adds a has_asterisk flag to detect when the statement begins with an asterisk operator and skips the function call check in this case, allowing the existing pointer dereference handling code to process the statement correctly.
Integrate AddressSanitizer and UndefinedBehaviorSanitizer testing into the GitHub Actions workflow to catch memory safety and undefined behavior issues early in the development cycle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds memory safety improvements:
Makefile- Added build targets for AddressSanitizer and UndefinedBehaviorSanitizerarena_allocwitharena_calloc- Changed structure allocations to zero-initialize memory, preventing undefined behavior*ptr = valueSummary by Bito
This pull request enhances memory safety by integrating sanitizer support, fixing memory alignment issues for 64-bit systems, and replacing arena_alloc with arena_calloc to ensure zero-initialized memory. It also addresses a parser crash related to pointer dereferencing, improving overall stability.