Implement arena memory compaction #255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrXiao
reviewed
Aug 21, 2025
src/globals.c
Outdated
Comment on lines
1188
to
1201
| saved = arena_free_trailing_blocks(BLOCK_ARENA); | ||
| total_saved += saved; | ||
|
|
||
| saved = arena_free_trailing_blocks(INSN_ARENA); | ||
| total_saved += saved; | ||
|
|
||
| saved = arena_free_trailing_blocks(BB_ARENA); | ||
| total_saved += saved; | ||
|
|
||
| saved = arena_free_trailing_blocks(HASHMAP_ARENA); | ||
| total_saved += saved; | ||
|
|
||
| saved = arena_free_trailing_blocks(GENERAL_ARENA); | ||
| total_saved += saved; |
There was a problem hiding this comment.
I think it can be refined as follows:
int total_saved = 0;
/* Free trailing blocks from each arena */
total_saved += arena_free_trailing_blocks(BLOCK_ARENA);
total_saved += arena_free_trailing_blocks(INSN_ARENA);
total_saved += arena_free_trailing_blocks(BB_ARENA);
total_saved += arena_free_trailing_blocks(HASHMAP_ARENA);
total_saved += arena_free_trailing_blocks(GENERAL_ARENA);This commit adds arena compaction mechanism that safely reclaims memory by freeing trailing empty blocks after compilation phases, reducing memory usage by 1200 KiB typically.
jserv
force-pushed
the
arena-compaction
branch
from
eb7aa38 to
ddecbd2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds arena compaction mechanism that safely reclaims memory by freeing trailing empty blocks after compilation phases, reducing memory usage by 1200 KiB typically.
Summary by Bito
This pull request introduces an arena memory compaction mechanism that improves memory management by reclaiming memory from trailing empty blocks after compilation. It includes new compaction flags, functions for execution, and integration into the compilation workflow, aiming to reduce memory usage by approximately 1200 KiB.