Fix pointer aliasing bug in constant optimization #271
+42
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Variables modified through pointers incorrectly returned cached constant values instead of reloading from memory. This caused wrong results when a variable was initialized with a constant, had its address taken, and was modified through pointer indirection. Example that was broken: int b = 10; int *a = &b; a[0] = 5; return b; Previously returned 10 (cached), now correctly returns 5 (reloaded).
jserv
force-pushed
the
pointer-aliasing
branch
from
58cb1fe to
32cf8c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Variables modified through pointers incorrectly returned cached constant values instead of reloading from memory. This caused wrong results when a variable was initialized with a constant, had its address taken, and was modified through pointer indirection.
Example that was broken:
Previously returned 10 (cached), now correctly returns 5 (reloaded).