Cleanup stale TODO comments #300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jserv
reviewed
Sep 11, 2025
Phi instructions in SSA unit is previously allocated via builtin malloc, and wasn't freeing after SSA unit completed. Later, we replaced allocator with arena allocator, which guaranteed its lifetime is within the compilation, thus the TODO comment is removed as resolved. Close sysprog21#275.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
ChAoSUnItY
force-pushed
the
fix/lsan
branch
from
7b257a8 to
3a32201
Compare
ChAoSUnItY
changed the title
|
Thank @ChAoSUnItY for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phi instructions in SSA unit is previously allocated via builtin
malloc, and wasn't freeing after SSA unit completed. Later, we
replaced allocator with arena allocator, which guaranteed its lifetime
is within the compilation, thus the TODO comment is removed as resolved.
Close #275.
Summary by cubic
Enable LeakSanitizer in the sanitizer build to catch memory leaks during compiler tests. Adds -fsanitize=leak to CFLAGS/LDFLAGS and removes a stale TODO about freeing SSA phi instruction memory.