Support function-like macro #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation redirects the pointer to the source to the beginning of the body of the macro, like how the copy and paste works. Because of this, the answer of the second test is 7, not 9. The '__VA_ARGS__' identifier will expand the remained arguments that are undeclared. It is useful to write the more readable codes. Not support nested macro yet.
jserv
reviewed
Aug 6, 2023
jserv
reviewed
Aug 6, 2023
jserv
reviewed
Aug 6, 2023
jserv
reviewed
Aug 7, 2023
jserv
reviewed
Aug 7, 2023
jserv
requested changes
Aug 7, 2023
vacantron
commented
Aug 7, 2023
jserv
reviewed
Aug 7, 2023
jserv
reviewed
Aug 7, 2023
This reverts commit 0defc31.
Both the arguments declared in function and macro can be accessed in thier children blocks. If we know which function or macro a block belongs to, we can trace its variables. The simple way to do this is recording them in the `block_t` structure. Drop `prev_return_idx` in `macro_t` because we only support non-nested macro. It used to record the return index of its parent. Change the prototype of `add_block` in `src/globals.c` to keep the semantics clear.
|
Thank @vacantron for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation redirects the pointer to the source to the beginning of the body of the macro, like how the copy and paste works. Because of this, the answer of the second test is 7, not 9.
The
__VA_ARGS__identifier will expand the remained arguments that are undeclared. It is useful to write the more readable codes.Not support nested macro yet.