Cleanups for missing_xyz.h headers #37904
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
journal
nspawn
resolve
login
sd-bus
analyze
build-system
util-lib
tmpfiles
tests
import
ask-password
sd-event
random-seed
sd-id128
mount
meson
volatile
creds
ssh-generator
nsresource
please-review
|
I'm not a fan of splitting missing_syscall.h. having a uniform location for trivial syscall wrappers makes sense, whereas they don't really fit into *-util owned by us. Also I'd really like those to remain static inline. |
yuwata
force-pushed
the
cleanup-missing-headers
branch
from
7e49f0e to
14ad02f
Compare
That introduces many unnecessary header inclusion. E.g. when we want to use move_mount() in a .c file, then it needed to include many irrelevant headers for defining syscalls that are not used in the .c file. |
yuwata
force-pushed
the
cleanup-missing-headers
branch
2 times, most recently
from
d6e2519 to
c27bfba
Compare
yuwata
force-pushed
the
cleanup-missing-headers
branch
from
c27bfba to
86a379a
Compare
keszybz
added
the
ci-fails/needs-rework 🔥
DaanDeMeyer
approved these changes
Jul 10, 2025
yuwata
force-pushed
the
cleanup-missing-headers
branch
from
4d841a5 to
6a0e5ef
Compare
github-actions
bot
added
please-review
|
Re-rebased to fix the conflict with bpf-delegate generator. |
yuwata
added
good-to-merge/waiting-for-ci 👍
yuwata
force-pushed
the
cleanup-missing-headers
branch
3 times, most recently
from
ad6590d to
732094e
Compare
…el headers to src/include/uapi/ Preparation for later changes.
yuwata
force-pushed
the
cleanup-missing-headers
branch
from
732094e to
53f279b
Compare
- pass our system include directories to make generators use our libc wrappers and latest kernel headers, - include relevant headers in generated gperf file, - use files() rather than find_program(), as the result of find_program() cannot be passed to 'input' of custom_target(), - move generate-bpf-delegate-configs.py to src/core/, as it is only used by libcore.
…all.h This also moves syscall tables and generators to the same directory. Note, inclusion of asm/sgidefs.h is dropped, as it is already included by unistd.h and sys/syscall.h.
Then, move syscall definitions to the wrapper, and prototypes are moved to relevant headers. This also adds checks for add_key() and request_key(), as one day glibc may be going to add some of them separatedly. The check for fspick in meson.build is dropped, as it is currently unused in our code. This also moves - basic/missing_bpf.h -> include/override/linux/bpf.h, - basic/missing_keyctl.h -> include/override/linux/keyctl.h.
To emphasize it is an array of bytes. This also align variables. No functional changes. Just refactoring.
The header raw-reboot.h is only used with reboot-util. Let's merge them.
Then, we can decrease the number of headers to be indirectly included by including raw-clone.h. No functional change.
yuwata
force-pushed
the
cleanup-missing-headers
branch
from
53f279b to
531e6a2
Compare
github-actions
bot
removed
the
good-to-merge/waiting-for-ci 👍
yuwata
added a commit
to yuwata/systemd
that referenced
this pull request
Jul 11, 2025
This also renames relevant files in the same way. Addresses systemd#37904 (comment)
yuwata
added a commit
that referenced
this pull request
Jul 11, 2025
This also renames relevant files in the same way. Addresses #37904 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #37960.
The same concern as expalined in #37960 exists also in missing_syscall.h. If we use enough new glibc, a function we want to use may be already provided by glibc, but our baseline glibc may not. And it is hard to detect in our daily development.
This moves all prototypes of syscalls to relevant headers, and missing syscall functions are defined in relevant .c files of libc wrapper. This way, we can use usual header as is, e.g. when we want to write code with
move_mount(), we can simply use sys/mount.h without checking if it is supported by our baseline glibc.