Skip to content

fix(hooks): memoize some returned methods in useDatepicker #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2021
Merged

fix(hooks): memoize some returned methods in useDatepicker #124

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
71 changes: 40 additions & 31 deletions packages/hooks/src/useDatepicker/useDatepicker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import {useState, useEffect} from 'react'
import {useState, useEffect, useCallback} from 'react'
import isBefore from 'date-fns/isBefore'
import isAfter from 'date-fns/isAfter'
import addDays from 'date-fns/addDays'
Expand Down Expand Up @@ -73,15 +73,15 @@ export function useDatepicker({
useEffect(() => {
if (typeof window !== 'undefined') {
if (window.addEventListener) {
window.addEventListener('keydown', handleKeyDown)
window.addEventListener('keydown', handleKeyDown)
}
}

return () => {
if (window.removeEventListener) {
window.removeEventListener('keydown', handleKeyDown)
}

return () => {
if (window.removeEventListener) {
window.removeEventListener('keydown', handleKeyDown)
}
}
})

const disabledDatesByUser = (date: Date) => {
Expand Down Expand Up @@ -286,44 +286,53 @@ export function useDatepicker({
}
}

function goToPreviousMonths() {
const goToPreviousMonths = useCallback(() => {
setActiveMonths(getNextActiveMonth(activeMonths, numberOfMonths, -1))
setFocusedDate(null)
}
}, [activeMonths, numberOfMonths])

function goToPreviousMonthsByOneMonth() {
const goToPreviousMonthsByOneMonth = useCallback(() => {
setActiveMonths(getNextActiveMonth(activeMonths, numberOfMonths, -1, 1))
setFocusedDate(null)
}
}, [activeMonths, numberOfMonths])

function goToNextMonths() {
const goToNextMonths = useCallback(() => {
setActiveMonths(getNextActiveMonth(activeMonths, numberOfMonths, 1))
setFocusedDate(null)
}
}, [activeMonths, numberOfMonths])

function goToNextMonthsByOneMonth() {
const goToNextMonthsByOneMonth = useCallback(() => {
setActiveMonths(getNextActiveMonth(activeMonths, numberOfMonths, 1, 1))
setFocusedDate(null)
}
}, [activeMonths, numberOfMonths])

function goToDate(date: Date) {
setActiveMonths(getInitialMonths(numberOfMonths, date))
setFocusedDate(null)
}
const goToDate = useCallback(
(date: Date) => {
setActiveMonths(getInitialMonths(numberOfMonths, date))
setFocusedDate(null)
},
[numberOfMonths],
)

function goToPreviousYear(numYears: number = 1) {
setActiveMonths(
getNextActiveMonth(activeMonths, numberOfMonths, -(numYears * 12 - numberOfMonths + 1)),
)
setFocusedDate(null)
}
const goToPreviousYear = useCallback(
(numYears: number = 1) => {
setActiveMonths(
getNextActiveMonth(activeMonths, numberOfMonths, -(numYears * 12 - numberOfMonths + 1)),
)
setFocusedDate(null)
},
[activeMonths, numberOfMonths],
)

function goToNextYear(numYears: number = 1) {
setActiveMonths(
getNextActiveMonth(activeMonths, numberOfMonths, numYears * 12 - numberOfMonths + 1),
)
setFocusedDate(null)
}
const goToNextYear = useCallback(
(numYears: number = 1) => {
setActiveMonths(
getNextActiveMonth(activeMonths, numberOfMonths, numYears * 12 - numberOfMonths + 1),
)
setFocusedDate(null)
},
[activeMonths, numberOfMonths],
)

return {
firstDayOfWeek,
Expand Down