-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: ⚡ Add /cli change validation to CI workflow #1625
ci: ⚡ Add /cli change validation to CI workflow #1625
Conversation
Added a new step in the CI workflow to check for changes in the /cli directory. If there are any changes, it will validate the changeset by running `pnpm changeset status --since origin/next`. This ensures that changes made to /cli are properly tracked and validated. Should allow for changes to www and docs to be free from ci errors around changeset
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@Jacksonmills is attempting to deploy a commit to the t3-oss Team on Vercel. A member of the Team first needs to authorize it. |
thanks for picking this up! the current version seems to hit false negatives, see #1626 also @juliusmarminge do we also need to include a few files in root such as eslintrc, prettier config, etc? i'm leaning no, because none of them should change the ux of using the cli |
Ah okay thanks for adding the test PR, I'll see what's going on with that |
…ent commit. Also, validate changesets only if changes are made in /cli directory.
Running all the tests ... but it seems the grep command was the culprit, needed to return true if grep doesn't find any matches, allowing the script to proceed to the else block gracefully. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
working great now. thanks so much for adding this!
Should allow for changes to www and docs to be free from ci errors around changeset, I have little exp working with the ci but thought I would try my attempt at a fix!
Closes #1623
✅ Checklist
Changelog
Added a new step in the CI workflow to check for changes in the /cli directory. If there are any changes, it will validate the changeset by running
pnpm changeset status --since origin/next
. This ensures that changes made to /cli are properly tracked and validated.💯⚡