-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.github/workflows/main.workflow #4
Open
t4n6a1ka
wants to merge
10,000
commits into
t4n6a1ka:master
Choose a base branch
from
golang:master
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gopherbot
force-pushed
the
master
branch
17 times, most recently
from
October 3, 2019 13:01
64785bf
to
3d437ac
Compare
gopherbot
force-pushed
the
master
branch
13 times, most recently
from
October 9, 2019 22:40
07b4abd
to
19a7490
Compare
As of version 0.5.0 and Go 1.22 it no longer linknames cheaprand. Fixes #67709 Change-Id: Ie00900e6428244fa1506bc509c265c10dc322f7a Reviewed-on: https://go-review.googlesource.com/c/go/+/589555 Auto-Submit: Ian Lance Taylor <iant@golang.org> Reviewed-by: Michael Knyszek <mknyszek@google.com> Reviewed-by: Than McIntosh <thanm@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Like IPv6Unspecified which is already covered in that test. Change-Id: I2bac4c50577c4c2c91cea26b9fbed88327cef516 Reviewed-on: https://go-review.googlesource.com/c/go/+/589595 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Ian Lance Taylor <iant@google.com> Reviewed-by: Carlos Amedee <carlos@golang.org> Auto-Submit: Tobias Klauser <tobias.klauser@gmail.com>
Brings in the latest github.com/google/pprof. Fixes #67626 Change-Id: Id8faef20f0a9bf81dd117110bf540aca852db6be Cq-Include-Trybots: luci.golang.try:gotip-linux-amd64-longtest Reviewed-on: https://go-review.googlesource.com/c/go/+/588655 Reviewed-by: Carlos Amedee <carlos@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Change-Id: Ideb9ef00e7bc660b005fc080973fd9f3d36c5a1f Reviewed-on: https://go-review.googlesource.com/c/go/+/589536 TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Michael Knyszek <mknyszek@google.com> Run-TryBot: shuang cui <imcusg@gmail.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Auto-Submit: Ian Lance Taylor <iant@google.com> Reviewed-by: Ian Lance Taylor <iant@google.com>
Change-Id: I5aaea4918f024a87146ba54a8d5307658d722fe9 Reviewed-on: https://go-review.googlesource.com/c/go/+/589635 Auto-Submit: Ian Lance Taylor <iant@google.com> Reviewed-by: hui zhou <hxzhouh@gmail.com> Reviewed-by: Ian Lance Taylor <iant@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Michael Knyszek <mknyszek@google.com>
Commands run: go get golang.org/x/telemetry@4691165 go mod vendor go mod tidy Change-Id: Icc72e77bab5e9687fbef74ada812708180725869 Reviewed-on: https://go-review.googlesource.com/c/go/+/590076 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Sam Thanawalla <samthanawalla@google.com>
For #61405. Fixes #65237. Change-Id: Ia7820c0ef089c828ea7ed3d2802c5185c945290e Reviewed-on: https://go-review.googlesource.com/c/go/+/589397 TryBot-Bypass: Robert Griesemer <gri@google.com> Reviewed-by: Robert Griesemer <gri@google.com> Auto-Submit: Robert Griesemer <gri@google.com> Reviewed-by: Matthew Dempsky <mdempsky@google.com> Reviewed-by: Ian Lance Taylor <iant@golang.org>
Use the bogo JSON output format to make the test output more readable. Cq-Include-Trybots: luci.golang.try:gotip-linux-amd64-longtest Change-Id: Ie1a67c6a031bc1d5d8b2cdfaf78d094a0967bc2a Reviewed-on: https://go-review.googlesource.com/c/go/+/587955 Reviewed-by: Michael Knyszek <mknyszek@google.com> Reviewed-by: Filippo Valsorda <filippo@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
The Go 1.23 code freeze has recently started. This is a time to update all golang.org/x/... module versions that contribute packages to the std and cmd modules in the standard library to latest master versions. For #36905. [git-generate] go install golang.org/x/build/cmd/updatestd@latest go install golang.org/x/tools/cmd/bundle@latest updatestd -goroot=$(pwd) -branch=master Change-Id: I9162f547c148809d6fb1e4157f6f504634cef3b7 Reviewed-on: https://go-review.googlesource.com/c/go/+/589935 Auto-Submit: Michael Knyszek <mknyszek@google.com> Reviewed-by: Matthew Dempsky <mdempsky@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Use a stat to tell the test caching infrastructure that we care about the bogo config file. Change-Id: Iae2336bfc45cd6a9e73cb83a3b68ade8b4f23927 Reviewed-on: https://go-review.googlesource.com/c/go/+/589155 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Filippo Valsorda <filippo@golang.org> Reviewed-by: Michael Knyszek <mknyszek@google.com> Auto-Submit: Roland Shoemaker <roland@golang.org>
On Plan 9, the queryDNS function could return an error string, which was not handled in lookupCNAME. This change fixes lookupCNAME by handling the "resource does not exist; negrcode" error string. Fixes #67776. Change-Id: I73f3286b9524a504212ba4303606a245b4962b1f Reviewed-on: https://go-review.googlesource.com/c/go/+/589715 Reviewed-by: Ian Lance Taylor <iant@google.com> Run-TryBot: David du Colombier <0intro@gmail.com> TryBot-Bypass: David du Colombier <0intro@gmail.com> Reviewed-by: Mauri de Souza Meneguzzo <mauri870@gmail.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
In all of the Is* methods, check if the address is a v6 mapped v4 address, and unmap it if so. Thanks to Enze Wang of Alioth (@zer0yu) and Jianjun Chen of Zhongguancun Lab (@chenjj) for reporting this issue. Fixes #67680 Fixes CVE-2024-24790 Change-Id: I6bd03ca1a5d93a0b59027d861c84060967b265b0 Reviewed-on: https://go-internal-review.googlesource.com/c/go/+/1460 Reviewed-by: Russ Cox <rsc@google.com> Reviewed-by: Damien Neil <dneil@google.com> Reviewed-on: https://go-review.googlesource.com/c/go/+/590316 Reviewed-by: David Chase <drchase@google.com> Auto-Submit: Michael Knyszek <mknyszek@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
…509.OID Change-Id: Ia08673450edc93fe1a9c7c05b7e69a05cd5ac8b9 GitHub-Last-Rev: c396197 GitHub-Pull-Request: #64655 Reviewed-on: https://go-review.googlesource.com/c/go/+/548915 Reviewed-by: Michael Knyszek <mknyszek@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Roland Shoemaker <roland@golang.org>
For #65237. Change-Id: Id38747efebd46633f453eadaf68d818064faa778 Reviewed-on: https://go-review.googlesource.com/c/go/+/590396 Reviewed-by: Robert Griesemer <gri@google.com> TryBot-Bypass: Robert Griesemer <gri@google.com> Reviewed-by: Ian Lance Taylor <iant@google.com> Auto-Submit: Robert Griesemer <gri@google.com>
Fixes #67773 Change-Id: I05c9934a5b2719d22884c8546f4fadaa9978ac67 Reviewed-on: https://go-review.googlesource.com/c/go/+/589755 Auto-Submit: Ian Lance Taylor <iant@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Commit-Queue: Ian Lance Taylor <iant@google.com> Reviewed-by: Michael Pratt <mpratt@google.com> Reviewed-by: Ian Lance Taylor <iant@google.com> Auto-Submit: Ian Lance Taylor <iant@google.com>
For #65614. Change-Id: Idbbcb6eb57b7294d52b174c1aba74ca7aa1b8efd Reviewed-on: https://go-review.googlesource.com/c/go/+/590616 Reviewed-by: Ian Lance Taylor <iant@google.com> Reviewed-by: Robert Griesemer <gri@google.com> TryBot-Bypass: Robert Griesemer <gri@google.com>
The arch name of loong64 should be loongarch64 Fixes #67832 Change-Id: Ic5cf0f0274262a164bba78c426813a8b8851033b Reviewed-on: https://go-review.googlesource.com/c/go/+/590695 Reviewed-by: Than McIntosh <thanm@google.com> Auto-Submit: Ian Lance Taylor <iant@google.com> Reviewed-by: abner chenc <chenguoqi@loongson.cn> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Ian Lance Taylor <iant@google.com> Commit-Queue: Ian Lance Taylor <iant@google.com>
For #65614. Change-Id: I05b20a80b1163e1d3927c2f763ef6b7d20e6a937 Reviewed-on: https://go-review.googlesource.com/c/go/+/590617 Reviewed-by: Robert Griesemer <gri@google.com> Auto-Submit: Robert Griesemer <gri@google.com> TryBot-Bypass: Robert Griesemer <gri@google.com> Reviewed-by: Ian Lance Taylor <iant@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
For #65614 For #67470 Change-Id: Iba2f263f8ca1fb10c383e12ff3455aa86b26421d Reviewed-on: https://go-review.googlesource.com/c/go/+/590795 Commit-Queue: Ian Lance Taylor <iant@google.com> Reviewed-by: Ian Lance Taylor <iant@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Auto-Submit: Ian Lance Taylor <iant@golang.org> Reviewed-by: Alan Donovan <adonovan@google.com> Auto-Submit: Ian Lance Taylor <iant@google.com>
Use the default frame scheduler (currently round-robin) rather than overriding the default with the priority scheduler. The priority scheduler is slow, known buggy, and implements a deprecated stream prioritization mechanism. The default changed in x/net about a year ago, but we missed that net/http is overriding that default. Fixes #67706 Change-Id: I6d76dd0cc8c55eb5dec5cd7d25a5084877e8e8d9 Reviewed-on: https://go-review.googlesource.com/c/go/+/590796 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Jonathan Amsterdam <jba@google.com> Auto-Submit: Damien Neil <dneil@google.com>
The language change for the accepted range-over-func proposal #61405 was documented in CL 590616. Remove the corresponding 'TODO' entry. Also improve formatting slightly, and switch to preferred relative links. They'll work better in the long term and in more contexts. While here, also simplify the suggested line to preview release notes locally: setting the -content='' flag explicitly is no longer required as of CL 589936. For #65614. Change-Id: I6cee951b9ede33900bca48c9f709e3b2c5e87337 Reviewed-on: https://go-review.googlesource.com/c/go/+/590756 Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Robert Griesemer <gri@google.com>
Change-Id: I219c59b5efc2ed7fcfdd7cd3c418635831b17b8a Reviewed-on: https://go-review.googlesource.com/c/go/+/590835 Reviewed-by: Michael Knyszek <mknyszek@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Auto-Submit: Gopher Robot <gobot@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
… notes For #65614. Change-Id: I9487521817348053170da293c01ac55f6e3dcd20 Reviewed-on: https://go-review.googlesource.com/c/go/+/590895 Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Robert Griesemer <gri@google.com> Auto-Submit: Robert Griesemer <gri@google.com> TryBot-Bypass: Robert Griesemer <gri@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
This test can fail due to objects being incorrectly retained due to conservative scanning. Allow a bit of slop (1 accidentally retained object) to prevent flaky failures. Fixes #67204 "fixes" is a bit too strong a word. More like, hopefully reduces the false positive rate to something approaching 0. Change-Id: I09984f0cce50d8209aef19f3d89b0e295c86f8d1 Reviewed-on: https://go-review.googlesource.com/c/go/+/590615 Reviewed-by: Keith Randall <khr@google.com> Reviewed-by: Michael Knyszek <mknyszek@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Fixes #66358. Change-Id: Ic9bde88eabfb2a446d32e1dc5ac404a51ef49f11 Reviewed-on: https://go-review.googlesource.com/c/go/+/590635 Auto-Submit: Robert Griesemer <gri@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Ian Lance Taylor <iant@google.com> Reviewed-by: Robert Griesemer <gri@google.com>
Before this change, we didn't initialize the overlays in the fsys package or use the fsys logic to read the files, so overlays were not respected for go.work files. Initialize fsys before loading the go.work file (initialization is idempotent) and use the new fsys.ReadFile function to read the file instead of os.ReadFile. fsys.ReadFile just opens the file with fsys.Open and then calls io.ReadAll on it. (This is less efficient than what os.ReadFile does: os.ReadFile reads into a buffer it allocated that's the file's size while io.ReadAll doesn't know how big the file is so it just reads in 512 byte chunks.) Change-Id: Ic40bcbb483a16c5d4dd1d896306ea99a16f370f3 Reviewed-on: https://go-review.googlesource.com/c/go/+/590755 Reviewed-by: Sam Thanawalla <samthanawalla@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Auto-Submit: Michael Matloob <matloob@golang.org>
In addition, add a line number to the go.work error for multiple use statements for the same directory. Also clean up the error prefix for go.work errors now containing line numbers. Fixes #67623 Change-Id: Ia7edcc50f7d7ec907b4a9eb4fe270c75d04c1fa5 Reviewed-on: https://go-review.googlesource.com/c/go/+/590135 Reviewed-by: Sam Thanawalla <samthanawalla@google.com> Auto-Submit: Michael Matloob <matloob@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Between Go 1.18 and Go 1.22 go get printed a fatal error if -d was explicitly set to false. That behavior was reverted in CL 572176, when we made the -d flag a no-op, but it would make it easier to remove the -d flag in the future if we continue to print a fatal error if -d is explicitly set to false. This change brings back the fatal error for -d=false while keeping the warning printed for -d=true. For #43684 Change-Id: I38ae3a3619d408c0237ff485ddee4403b8188abd Reviewed-on: https://go-review.googlesource.com/c/go/+/591135 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Sam Thanawalla <samthanawalla@google.com>
When sending a request with an "Expect: 100-continue" header, we must send the request body before sending any further requests on the connection. When receiving a non-1xx response to an "Expect: 100-continue" request, send the request body if the connection isn't being closed after processing the response. In other words, if either the request or response contains a "Connection: close" header, then skip sending the request body (because the connection will not be used for further requests), but otherwise send it. Correct a comment on the server-side Expect: 100-continue handling that implied sending the request body is optional. It isn't. For #67555 Change-Id: Ia2f12091bee697771087f32ac347509ec5922d54 Reviewed-on: https://go-review.googlesource.com/c/go/+/591255 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Jonathan Amsterdam <jba@google.com>
A method receiver can be collected during the execution of that method. This does make sense when thinking about how the GC would work, but also seems not very obvious, so a point in the docs can increase the chance of avoiding issues caused by missing KeepAlive of method receivers. Change-Id: I6817237dd022b5729dbdcda1b9f70c7059605575 GitHub-Last-Rev: 878bf3f GitHub-Pull-Request: #67777 Reviewed-on: https://go-review.googlesource.com/c/go/+/589735 Auto-Submit: Ian Lance Taylor <iant@google.com> Reviewed-by: Keith Randall <khr@google.com> Reviewed-by: Keith Randall <khr@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Ian Lance Taylor <iant@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
workflow "Build and Publish" {
on = "push"
resolves = "Publish"
}
action "Lint" {
uses = "actions/action-builder/shell@master"
runs = "make"
args = "lint"
}
action "Test" {
uses = "actions/action-builder/shell@master"
runs = "make"
args = "test"
}
action "Build" {
needs = ["Lint", "Test"]
uses = "actions/action-builder/docker@master"
runs = "make"
args = "build"
}
action "Publish Filter" {
needs = ["Build"]
uses = "actions/bin/filter@master"
args = "branch master"
}
action "Docker Login" {
needs = ["Publish Filter"]
uses = "actions/docker/login@master"
secrets = ["DOCKER_USERNAME", "DOCKER_PASSWORD"]
}
action "Publish" {
needs = ["Docker Login"]
uses = "actions/action-builder/docker@master"
runs = "make"
args = "publish"
}