Fix missing table header bg color in Library Themes section of demo #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason every other example in the
Library Themessection is missing itsthbackground-color:table-header-bug.mp4
This change just adds the rule explicitly to
headerRowContainerStyle, the same as it is inrowContainerStyle:table-header-bug-fixed.mp4
Note: There was also a build error when running
npm run storybook:devModule not found: Error: Can't resolve 'styled-components'...which can be fixed by running
npm i styled-components, but I've left that out of this PR in case you wanted to handle it differently.