Skip to content

Update swagger config to parse new /info response schema. #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 20, 2019
Merged

Update swagger config to parse new /info response schema. #189

merged 2 commits into from
Feb 20, 2019

Conversation

jnegara
Copy link
Contributor

@jnegara jnegara commented Feb 19, 2019

Testing done:

  • In swagger editor, manually verified the response schema is correct + generates the correct model.
  • Verified it can parse the response from a local instance of TabPy server from the dev branch.

@jnegara jnegara self-assigned this Feb 19, 2019
@0golovatyi
Copy link
Contributor

Why the whole file shows as changed? Line ending? Need to know what causes this behavior.

0golovatyi
0golovatyi requested changes Feb 19, 2019
View reviewed changes
@jnegara jnegara force-pushed the add-features-to-info branch from 28d2749 to bca6ca9 Compare February 20, 2019 00:41
@jnegara jnegara merged commit 5fd4299 into dev Feb 20, 2019
@jnegara jnegara deleted the add-features-to-info branch February 20, 2019 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0golovatyi 0golovatyi 0golovatyi approved these changes

@tmartintableau tmartintableau tmartintableau approved these changes

@johng42 johng42 Awaiting requested review from johng42

Assignees

@jnegara jnegara

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jnegara @0golovatyi @tmartintableau