Skip to content

Conversation

sbabayan
Copy link
Contributor

@sbabayan sbabayan commented Apr 4, 2019

Updated documentation, added an integration test, and implemented PCA/SentimentAnalysis

@sbabayan sbabayan added the WIP Work in progress label Apr 4, 2019
@pep8speaks
Copy link

pep8speaks commented Apr 4, 2019

Hello @sbabayan! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 11:1: E402 module level import not at top of file
Line 13:1: E302 expected 2 blank lines, found 1
Line 62:5: E265 block comment should start with '# '
Line 65:10: W291 trailing whitespace
Line 72:9: E265 block comment should start with '# '
Line 75:9: E265 block comment should start with '# '
Line 75:35: W291 trailing whitespace

Line 7:1: E402 module level import not at top of file
Line 41:5: E265 block comment should start with '# '
Line 44:10: W291 trailing whitespace
Line 51:9: E265 block comment should start with '# '
Line 54:9: E265 block comment should start with '# '
Line 54:50: W291 trailing whitespace

Line 28:80: E501 line too long (80 > 79 characters)
Line 37:10: W291 trailing whitespace
Line 50:25: E127 continuation line over-indented for visual indent
Line 51:1: W391 blank line at end of file

Line 6:1: E302 expected 2 blank lines, found 1
Line 11:1: E302 expected 2 blank lines, found 1
Line 17:80: E501 line too long (136 > 79 characters)

Line 5:1: E302 expected 2 blank lines, found 1
Line 9:1: W293 blank line contains whitespace
Line 20:1: W293 blank line contains whitespace
Line 20:1: W391 blank line at end of file

Line 6:1: E302 expected 2 blank lines, found 1
Line 20:80: E501 line too long (82 > 79 characters)
Line 22:1: W293 blank line contains whitespace

Line 6:1: E302 expected 2 blank lines, found 1
Line 7:4: E111 indentation is not a multiple of four
Line 8:7: E111 indentation is not a multiple of four
Line 10:4: E111 indentation is not a multiple of four
Line 11:7: E111 indentation is not a multiple of four
Line 13:4: E111 indentation is not a multiple of four
Line 14:7: E111 indentation is not a multiple of four
Line 15:1: W293 blank line contains whitespace
Line 16:4: E111 indentation is not a multiple of four
Line 17:7: E111 indentation is not a multiple of four
Line 18:7: E111 indentation is not a multiple of four
Line 20:7: E111 indentation is not a multiple of four
Line 21:7: E114 indentation is not a multiple of four (comment)
Line 22:7: E111 indentation is not a multiple of four
Line 23:7: E114 indentation is not a multiple of four (comment)
Line 24:7: E111 indentation is not a multiple of four
Line 25:1: W293 blank line contains whitespace
Line 26:7: E111 indentation is not a multiple of four
Line 28:7: E111 indentation is not a multiple of four
Line 29:1: W293 blank line contains whitespace
Line 30:7: E111 indentation is not a multiple of four
Line 30:80: E501 line too long (88 > 79 characters)
Line 33:7: E111 indentation is not a multiple of four
Line 34:1: W391 blank line at end of file

Line 7:1: E302 expected 2 blank lines, found 1
Line 30:80: E501 line too long (82 > 79 characters)
Line 41:44: E251 unexpected spaces around keyword / parameter equals
Line 44:80: E501 line too long (87 > 79 characters)
Line 45:36: E128 continuation line under-indented for visual indent
Line 46:36: E128 continuation line under-indented for visual indent
Line 47:36: E128 continuation line under-indented for visual indent
Line 47:44: E251 unexpected spaces around keyword / parameter equals
Line 49:1: W293 blank line contains whitespace
Line 50:1: W293 blank line contains whitespace
Line 50:1: W391 blank line at end of file

Comment last updated at 2019-05-10 23:03:59 UTC

Copy link
Contributor

@jnegara jnegara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Copy link
Contributor

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments in case they help

Copy link
Contributor

@jnegara jnegara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on olek's feedback, but once that's addressed ship it!

@0golovatyi
Copy link
Contributor

Oh, one thing - could you update VERSION file?

Copy link
Contributor

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job - this has really come a long ways. Just some more ideas in case they are helpful

@sbabayan sbabayan removed the WIP Work in progress label May 10, 2019
@sbabayan sbabayan merged commit 1d69226 into dev May 10, 2019
@sbabayan sbabayan deleted the models branch May 10, 2019 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants