Skip to content

Conversation

0golovatyi
Copy link
Contributor

Update documentation for how to use set_credentials

## Authentication

When TabPy is configured with authentication feature on client code
has to specify credential to use during model deployment with
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be

When TabPy is configured with the authentication feature on, client code
has to specify the credentials to use during model deployment with

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

CHANGELOG Outdated
### Improvements

- Added basic access authentication (all methods except /info)
- tabpy-tools can deploy to TabPy with auth on
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be

tabpy-tools can deploy models to TabPy with authentication on

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Copy link
Contributor

@johng42 johng42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some grammar nitpicking

Copy link
Contributor

@johng42 johng42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@johng42 johng42 merged commit a4367bf into dev Apr 4, 2019
@johng42 johng42 deleted the dev_tools_doc branch April 4, 2019 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants