Add CI integration tests #269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
April 22, 2019 17:01
sbabayan
reviewed
Apr 24, 2019
CONTRIBUTING.md
Outdated
| ``` | ||
|
|
||
| ## Linux and Mac Specific Steps | ||
| ## TabPy in Pythong Virtual Environment |
docs/api-v1.md
Outdated
| --- | --- | ||
| `required` | Authentication is never optional for client to use if it is mentioned in features list. | ||
| `methods` | List of supported authentication methods with their properties. | ||
| `methods.basic-auth` | TabPy requires to use basic access authenticatio, see [TabPy Server Configuration Instructions](server-config.md#authentication) for how to configure authentication. |
docs/server-config.md
Outdated
| - [Authentication](#authentication) | ||
| * [Enabling Authentication](#enabling-authentication) | ||
| * [Password File](#password-file) | ||
| * [setting Up Environmnet](#setting-up-environmnet) |
tests/integration/test_auth.py
Outdated
| self.tmp_dir = tempfile.mkdtemp(prefix=prefix) | ||
|
|
||
| # create temporary state.ini | ||
| self.state_file = open(os.path.join(self.tmp_dir, 'state.ini'), 'w+') |
There was a problem hiding this comment.
rather than creating a temporary state.ini and config for each test run, should we just keep local copies in the test folder?
There was a problem hiding this comment.
One reason I didn't do it is we can move this code in some integration test base class to be reused. This is why I want to keep it as generic as possible right now - we will need new state.ini for models tests.
jnegara
requested changes
Apr 25, 2019
CONTRIBUTING.md
Outdated
|
|
||
| If you have downloaded Tabpy and would like to manually install Tabpy Server | ||
| not using pip then follow the steps below [to run TabPy in Python virtual environment](docs/tabpy-virtualenv.md). | ||
| not using pip then follow the steps below |
There was a problem hiding this comment.
We don't support installing TabPy via pip anymore.
|
Added new integration tests and fixes for code review feedback. |
sbabayan
approved these changes
Apr 25, 2019
jnegara
approved these changes
Apr 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.