Skip to content

Conversation

sulaxd
Copy link
Contributor

@sulaxd sulaxd commented May 2, 2019

Tableau Server 2018.2 (Windows) / Tableau Server 10.5 (Linux) and Newer Versions:

Tableau Server 2018.2 (Windows) / Tableau Server 10.5 (Linux) and Newer Versions:
Copy link
Contributor

@0golovatyi 0golovatyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johng42
Copy link
Contributor

johng42 commented May 2, 2019

Build failed - https://travis-ci.com/tableau/TabPy/builds/110331602

More specifically,
docs/TableauConfiguration.md: 40: MD013/line-length Line length [Expected: 80; Actual: 106]

so just adjust the length of line 40 to not be more than 80 characters and resubmit.

Thanks for helping!

- adjust the length of line 40 to not be more than 80 characters
- also fix line 36
- btw, I got error when I use version `2018.2.0 (20182.18.0627.2230) 64-bit Windows`, same with [](tableau#128)
@sulaxd sulaxd mentioned this pull request May 3, 2019
@johng42
Copy link
Contributor

johng42 commented May 3, 2019

Line 36 is still too long:
docs/TableauConfiguration.md: 36: MD013/line-length Line length [Expected: 80; Actual: 137]

@sulaxd
Copy link
Contributor Author

sulaxd commented May 3, 2019 via email

@0golovatyi
Copy link
Contributor

@sulaxd As mentioned in contributing guide you can use https://dlaa.me/markdownlint/ to validate documentation format.

@sulaxd
Copy link
Contributor Author

sulaxd commented May 3, 2019 via email

@johng42
Copy link
Contributor

johng42 commented May 6, 2019

Thanks for spotting this - good eye.

@johng42 johng42 merged commit 3820cd1 into tableau:master May 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants