Skip to content

#162 preserve the xmlns:user namespace when saving a file #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 27, 2021
Merged

#162 preserve the xmlns:user namespace when saving a file #196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6b0df5b
preserve the xmlns:user namespace when saving a file
jacalata May 27, 2021
5c16c60
pycodestyle
jacalata May 27, 2021
5af93c9
update changelog and version
jacalata May 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@

## 07 (26 May 2021)
* Fix bug in xfile that overwrote the namespace name when saving a document

## 06 (11 January 2017)

* Initial SQL and query banding support (#123)
Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

setup(
name='tableaudocumentapi',
version='0.6',
version='0.7',
author='Tableau',
author_email='github@tableau.com',
url='https://github.com/tableau/document-api-python',
Expand Down
1 change: 1 addition & 0 deletions tableaudocumentapi/xfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,7 @@ def save_into_archive(xml_tree, filename, new_filename=None):

def _save_file(container_file, xml_tree, new_filename=None):

ET.register_namespace("user", "http://www.tableausoftware.com/xml/user")
if new_filename is None:
new_filename = container_file

Expand Down