-
Notifications
You must be signed in to change notification settings - Fork 0
feat: links to original pdfs from web versions of whitepapers #616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There are spelling issues in the whitepapers, attempting to fix all... UPD: I was also re-doing all the regex ignores as part of the #617, but that task helped discover that almost none are needed, actually. However, there were edge-cases I could not resolve easily enough, and fixing spelling in all files should be one of the last tasks before the actual public release. |
Thanks for the PR. I reviewed the changes for this branch and found no issues; no fixes are needed. |
TL;DR: This PR is complete despite false-positives in spellchecks.There are false-positives in whitepaper spellchecks and they cannot be ignored with I've tried to debug the issue and modify the configuration (#617) to significantly reduce the number of RegExes, aiming to decrease the rate of false positives and uncover possible overlooked spelling errors. There were a couple of issues with that: small reproducible samples and low confidence in RegExes (e.g., they might not encompass all cases, but they should not induce false-positives). I'll resume work on that later as per #617 as this is not a pressing issue for the time being. |
Thanks for the updates. I reviewed the changes between |
Closes #567
Here's an example: