Feature/railties 7 #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
tagliala
commented
Dec 14, 2021
•
tagliala
commented
⚠️ DO NOT RELY ON THIS BRANCH FOR DEPLOYMENT ⚠️
tagliala
force-pushed
the
feature/railties-7
branch
2 times, most recently
from
64604ad
to
a771967
Compare
tagliala
force-pushed
the
feature/railties-7
branch
8 times, most recently
from
9a9b17f
to
bc1e8e4
Compare
tagliala
force-pushed
the
feature/railties-7
branch
16 times, most recently
from
48fc4ee
to
12ef798
Compare
tagliala
force-pushed
the
feature/railties-7
branch
2 times, most recently
from
93b4a3e
to
8ccc35b
Compare
tagliala
force-pushed
the
feature/railties-7
branch
3 times, most recently
from
920f143
to
5d6dfbe
Compare
tagliala
force-pushed
the
feature/railties-7
branch
3 times, most recently
from
3927b00
to
a8ce826
Compare
tagliala
force-pushed
the
feature/railties-7
branch
from
a8ce826
to
000dd94
Compare
|
@tagliala I am getting this issue with
|
|
just run Please also do not rely on this branch for deployments |
@tagliala then what is the solution to use activeadmin with rails 7? Please suggest. |
|
@sachin-amzur you can fork this repo and point your gemfile to a branch you have control on |
tagliala
force-pushed
the
feature/railties-7
branch
2 times, most recently
from
2443ab3
to
871c6af
Compare
`cucumber-rails` 2.5 with Rails 7 support has not been released yet at the time of this commit This change will allow activeadmin#7235 to be merged
tagliala
force-pushed
the
feature/railties-7
branch
3 times, most recently
from
68da7a1
to
3299528
Compare
Bumps [rollup](https://github.com/rollup/rollup) from 2.69.0 to 2.69.2. - [Release notes](https://github.com/rollup/rollup/releases) - [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md) - [Commits](rollup/rollup@v2.69.0...v2.69.2) --- updated-dependencies: - dependency-name: rollup dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [github-pages](https://github.com/github/pages-gem) from 224 to 225. - [Release notes](https://github.com/github/pages-gem/releases) - [Commits](github/pages-gem@v224...v225) --- updated-dependencies: - dependency-name: github-pages dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
…nd_yarn/rollup-2.69.2 Bump rollup from 2.69.0 to 2.69.2
…er/docs/github-pages-225 Bump github-pages from 224 to 225 in /docs
- Relax railties dependency to allow 7.0 - Move Rails 6.1 Gemfile to gemfiles directory - Set main test application to Rails 7.0
This method has been removed in Rails 7 and replaced with `constantize`
`ActiveAdmin::Aplication.remove_active_admin_load_paths_from_rails_autoload_and_eager_load`
is not working on feature tests.
Starting from Rails 7.0, running tests with eager_load enabled produces the following error:
```
Failure/Error: require
"#{ActiveAdmin::TestApplication.new.full_app_dir}/config/environment.rb"
FrozenError:
can't modify frozen Array: ["<root>/tmp/test_apps/rails_70/app/admin",
"<root>/tmp/test_apps/rails_70/app/channels",
"<root>/tmp/test_apps/rails_70/app/controllers",
"<root>/tmp/test_apps/rails_70/app/controllers/concerns",
"<root>/tmp/test_apps/rails_70/app/helpers",
"<root>/tmp/test_apps/rails_70/app/jobs",
"<root>/tmp/test_apps/rails_70/app/mailers",
"<root>/tmp/test_apps/rails_70/app/models",
"<root>/tmp/test_apps/rails_70/app/models/concerns",
"<root>/tmp/test_apps/rails_70/app/policies"
```
`ActiveAdmin::Aplication.remove_active_admin_load_paths_from_rails_autoload_and_eager_load`
fails because `ActiveAdmin.application.load_paths` value is
`<root>/app/admin` when it should be `<root>/tmp/test_apps/rails_70/app/admin`.
`ActiveAdmin::ApplicationSettings` initialize `load_path` with
`[File.expand_path("app/admin", Rails.root)]`.
On testing app bootstrap ([this line](https://github.com/activeadmin/activeadmin/blob/master/features/support/env.rb#L12))
`Rails.root` is nil and `File.expand_path` is expanding to the folder where
`rake test` runs (`<root>`).
`ActiveAdmin::Engine` has an initializer to define default value for
`load_paths`. The problem is that the block runs after initializers in
`config/initializers` folder, including `ActiveAdmin.setup` where
`ActiveAdmin::Aplication.remove_active_admin_load_paths_from_rails_autoload_and_eager_load`
is called from.
This commit makes sure the block runs before `config/initializers`.
That way the block sets a proper default.
At the moment of this commit, JRuby does not support Ruby 2.7, the minimum version required to run Rails 7.0, and gems did not install with jruby-head This platform can be added back when JRuby will release a version compatible with 2.7 MRI
tagliala
force-pushed
the
feature/railties-7
branch
from
3299528
to
73ce06e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.