Cross Platform Support #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @joealam this is really great stuff. I've been wanting to do this for quite some time now. It'll take me a bit of time to go over everything as I'm currently writing midterms. In the meantime take a look at the sound effects implementation in #48 and how that would tie in to cross-platform support. |
|
I'll take a look and add cross platform sound support. |
Conflicts: Turn/Turn.vcxproj Turn/Turn.vcxproj.filters
Fixed several include paths to use forward slashes instead of backslashes. Wrapped Windows-specific PlaySound code (cross platform implementation still todo) Conflicts: Turn/src/Player.cpp Turn/src/Store.cpp
Added dependency on WinMM for PlaySound Conflicts: Turn/Turn.vcxproj Turn/Turn.vcxproj.filters
|
Updated to latest and fixed up so it's ready to merge with no conflicts. |
|
Also, added compile fixes for Sound so it compiles and runs on both platforms, but currently doesn't actually do anything on Linux (I'll be starting that shortly) |
Merged
|
Implemented the sound support in #60. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cross platform support (see issue #52)
Key changes:
Depends on CMake, which is also included as a separate pull request (#57) for easier reviewing/merging.