Linux Audio Support #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: Turn/src/Game.cpp
Conflicts: Turn/Turn.vcxproj Turn/Turn.vcxproj.filters
Fixed several include paths to use forward slashes instead of backslashes. Wrapped Windows-specific PlaySound code (cross platform implementation still todo) Conflicts: Turn/src/Player.cpp Turn/src/Store.cpp
Added dependency on WinMM for PlaySound Conflicts: Turn/Turn.vcxproj Turn/Turn.vcxproj.filters
Merged
|
Tested on ubuntu mate. Installed the SDL2 mixer packages, build was successful but no sounds are played in-game. Is there anything in the setup that I'm missing? |
|
Make sure you're running from the correct working directory. The sound files all all referenced with their relative paths, so if it's executed from anywhere else the files won't be found.
…-------- Original message --------
From: "J.R. Maingat" <notifications@github.com>
Date: 28/10/2017 20:51 (GMT+00:00)
To: tagniam/Turn <Turn@noreply.github.com>
Cc: Joe Alam <joe@robotgoblin.co.uk>, Author <author@noreply.github.com>
Subject: Re: [tagniam/Turn] Linux Audio Support (#60)
Tested on ubuntu mate. Installed the SDL2 mixer packages, build was successful but no sounds are played in-game. Is there anything in the setup that I'm missing?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/tagniam/Turn","title":"tagniam/Turn","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/tagniam/Turn"}},"updates":{"snippets":[{"icon":"PERSON","message":"@tagniam in #60: Tested on ubuntu mate. Installed the SDL2 mixer packages, build was successful but no sounds are played in-game. Is there anything in the setup that I'm missing?"}],"action":{"name":"View Pull Request","url":"#60 (comment)"}}}
|
![https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open](https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open){kind=link}
|
Thanks, that worked. I had to run it from the |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented sound support on Linux via SDL_mixer.
Wrapped up some of the sound calls in a helper so the calling-code doesn't need to care which platform it's on.
This depends on the Cross Platform changes from #58