Magic folder integration tests #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| try: | ||
| mkdir(join(temp_dir, 'magic-alice')) | ||
| except OSError: | ||
| pass |
There was a problem hiding this comment.
Put this before creating the process.
|
Note to self: try on windows-vm to see if the appveyor failure is "real" or not. |
|
I've kicked appveyor to re-build that one, maybe it was something transient. |
|
Okay, I've addressed the comments and this is ready to go. Note that two of the tests will fail until the PR for 2814 is landed (if @warner agrees I can squash before merge if you want, perhaps after 2814 is landed so I can rebase it as well). |
|
looks reasonable to me, squash at will |
This introduces a py.test-based integration suite (currently just
containing magic-folder end-to-end tests). Also adds a tox environment
("integration") to run them.
The test setup is:
- a "flogtool gather" instance
- an Introducer
- five Storage nodes
- Alice and Bob client nodes
- Alice and Bob have paired magic-folders
meejah
force-pushed
the
magic-folder-integration-tests-pytest.2
branch
from
e05c06b
to
72f17af
Compare
|
Okay, I rebased to master and just squashed everything into one commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ports all the magic-folders integration-style tests (from
check_magicfolder_smoke.py) to a proper event-runner, etc. Usespy.testfixtures to build up the introducer, storage servers and alice + bob clients. It also runs aflog_toolgather instance to grab all logs from all the running services and dumps them at the end of the run.