Handle invalid responses on batch rpc providers #3615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue with some RPCs returning invalid responses for batch requests, such as receiving a single error object for a batch of rpc requests when `eth_call` fails.
Shadowfiend
approved these changes
Sep 5, 2023
|
Derp I didn't look closely enough. This is just happening because it's a fork run and doesn't have the full env. Going to land as is! |
Merged
Shadowfiend
added a commit
that referenced
this pull request
Sep 8, 2023
## Highlights - Fixed an issue where valid private keys would not be accepted. These always had one or more `0`s at the beginning. - Fixed an issue where certain types of errors were causing sites not to load correctly. ## What's Changed * v0.48.0 by @Shadowfiend in #3610 * Attempt to import private key to validate it by @jagodarybacka in #3614 * Group private keys when categorizing by @Shadowfiend in #3618 * Assert URL of the scan website opened for unverified assets by @michalinacienciala in #3602 * Handle invalid responses on batch rpc providers by @hyphenized in #3615 * Joint Privacy: Rework analytics service event management and add signing tracking by @Shadowfiend in #3623 **Full Changelog**: v0.48.0...v0.49.0 Latest build: [extension-builds-3625](https://github.com/tahowallet/extension/suites/15924368205/artifacts/909765830) (as of Thu, 07 Sep 2023 20:56:50 GMT).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue with some RPCs returning invalid responses for batch requests, such as receiving a single error object for a batch of RPC requests when a single
eth_callrequest fails.Closes #3605
To Test
git fetch git@github.com:hyphenized/tally-cash.git +bad-response && git checkout bad-response.diff/.patchto the end of this PR's URL and apply the diff manually 😉Latest build: extension-builds-3615 (as of Tue, 05 Sep 2023 21:18:44 GMT).