Group private keys when categorizing #3618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the signer id abstraction was introduced, I misunderstood each private key as needing to be treated as its own signer. In fact, we treat, on the UI side, all private keys as a single signer group. To fix this, rather than return the wallet id for the signer in these cases, we just return the constant string `"private-key"`. This ensures all private keys are categorized together.
Merged
Shadowfiend
added a commit
that referenced
this pull request
Sep 8, 2023
## Highlights - Fixed an issue where valid private keys would not be accepted. These always had one or more `0`s at the beginning. - Fixed an issue where certain types of errors were causing sites not to load correctly. ## What's Changed * v0.48.0 by @Shadowfiend in #3610 * Attempt to import private key to validate it by @jagodarybacka in #3614 * Group private keys when categorizing by @Shadowfiend in #3618 * Assert URL of the scan website opened for unverified assets by @michalinacienciala in #3602 * Handle invalid responses on batch rpc providers by @hyphenized in #3615 * Joint Privacy: Rework analytics service event management and add signing tracking by @Shadowfiend in #3623 **Full Changelog**: v0.48.0...v0.49.0 Latest build: [extension-builds-3625](https://github.com/tahowallet/extension/suites/15924368205/artifacts/909765830) (as of Thu, 07 Sep 2023 20:56:50 GMT).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the signer id abstraction was introduced, I misunderstood each private key as needing to be treated as its own signer. In fact, we treat, on the UI side, all private keys as a single signer group. To fix this, rather than return the wallet id for the signer in these cases, we just return the constant string
"private-key". This ensures all private keys are categorized together.Testing
0c1cd323ff8fd5b34f260d580c3a843f3e06c3e1e31c357d38a4a22e8b26809b(used for testing 0-leading private key imports) and1c1cd323ff8fd5b34f260d580c3a843f3e06c3e1e31c357d38a4a22e8b26809b(swaps the 0 to a 1 in the previous key) as private keys.Fixes #3606.
Latest build: extension-builds-3618 (as of Sun, 03 Sep 2023 04:04:18 GMT).