Joint Privacy: Rework analytics service event management and add signing tracking #3623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnalyticsService should act as an event sink and manage events internally to the extent possible. In particular, InternalSignerService no longer depends on AnalyticsService, but rather vice versa. This sets the stage for also tracking signing events centrally in AnalyticsService.
Nothing is recorded about the signature other than the fact that data was signed. Failures track error reason, which is a very limited set of possible errors managed by the `SigningService`. Notably, this commit also moves handling for transaction signatures out of `Main` and into `AnalyticsService`, which should be loosely coupled to service events when possible.
Shadowfiend
force-pushed
the
joint-privacy
branch
from
390a542
to
56e412e
Compare
jagodarybacka
approved these changes
Sep 6, 2023
Merged
Shadowfiend
added a commit
that referenced
this pull request
Sep 8, 2023
## Highlights - Fixed an issue where valid private keys would not be accepted. These always had one or more `0`s at the beginning. - Fixed an issue where certain types of errors were causing sites not to load correctly. ## What's Changed * v0.48.0 by @Shadowfiend in #3610 * Attempt to import private key to validate it by @jagodarybacka in #3614 * Group private keys when categorizing by @Shadowfiend in #3618 * Assert URL of the scan website opened for unverified assets by @michalinacienciala in #3602 * Handle invalid responses on batch rpc providers by @hyphenized in #3615 * Joint Privacy: Rework analytics service event management and add signing tracking by @Shadowfiend in #3623 **Full Changelog**: v0.48.0...v0.49.0 Latest build: [extension-builds-3625](https://github.com/tahowallet/extension/suites/15924368205/artifacts/909765830) (as of Thu, 07 Sep 2023 20:56:50 GMT).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two core things:
Note that there is still a lot of unnecessary event management happening in
Main, which should just be event observations fromAnalyticsService. These can be handled at a later time.Latest build: extension-builds-3623 (as of Wed, 06 Sep 2023 10:24:01 GMT).