Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0.48.0 #3610

Merged
merged 1 commit into from
Sep 2, 2023
Merged

v0.48.0 #3610

merged 1 commit into from
Sep 2, 2023

Conversation

Shadowfiend
Copy link
Contributor

@Shadowfiend Shadowfiend commented Aug 31, 2023 •
edited by github-actions bot
Loading

What's Changed

Full Changelog: v0.47.0...v0.48.0

Latest build: extension-builds-3610 (as of Thu, 31 Aug 2023 16:31:16 GMT).

@github-actions
Copy link

github-actions bot commented Aug 31, 2023 •
edited by andreachapman
Loading

Release checklist

This release checklist should be performed before release is published.

  • dev tests should be performed by the dev team
  • if something is not working please create an issue and link it here. Checkbox should be checked only if everything was fine
  • in case of serious issues or doubts you should ask the team first

Don't forget to approve the PR when checklist is finished ✅

Dev tests

🚀 Version update

  • update from previous version with some accounts loaded

Manual tests

📨 Add account

  1. Add read-only account with ENS
    • check assets
    • check balance
    • check NFTs
    • check abilities (abilities should not be displayed)
    • check activities
    • check portfolio page
    • check export options (export recovery phase and export private key should not be available)
  2. Add read-only account with UNS
    • check assets
    • check balance
    • check NFTs
    • check abilities (abilities should not be displayed)
    • check activities
    • check portfolio page
    • check export options (export recovery phase and export private key should not be available)
  3. Add read-only account with 0x address
    • check assets
    • check balance
    • check NFTs
    • check abilities (abilities should not be displayed)
    • check activities
    • check portfolio page
    • check export options (export recovery phase and export private key should not be available)
  4. Import account with a seed phrase
    • check assets
    • check balance
    • check NFTs
    • check abilities
    • check activities
    • check portfolio page
    • check seed phrase export
    • check private key export for first account
  5. Add another account from the same seed phrase
    • check assets
    • check balance
    • check NFTs
    • check abilities
    • check activities
    • check portfolio page
    • check private key export for second account
  6. Add account with a Ledger
    • check assets
    • check balance
    • check NFTs
    • check abilities
    • check activities
    • check portfolio page
    • check export options (export recovery phase and export private key should not be available)
  7. Create new wallet
    • check assets
    • check balance
    • check NFTs
    • check abilities
    • check activities
    • check portfolio page
    • check private key export
  8. Add account with private key
    • check assets
    • check balance
    • check NFTs
    • check abilities
    • check activities
    • check portfolio page
    • check private key export
  9. Add account with JSON keystore
    • check assets
    • check balance
    • check NFTs
    • check abilities
    • check activities
    • check portfolio page
    • check private key export

🗑️ Remove account

  1. Remove account by type
    • remove read-only account
    • remove address from imported account
    • remove Ledger account
    • remove account imported with private key
    • remove account imported with JSON keystore
    • remove selected account
    • remove not selected account
    • remove all accounts
  2. Remove account and check functionalities
    • add removed address from imported account
    • remove all addresses from imported account
    • check if NFTs are removed for removed accounts
    • check if abilities are removed for removed accounts
    • check if Portfolio page is updated for removed accounts

💌 Send base asset

  1. Ethereum mainnet
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  2. Polygon
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  3. Optimism
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  4. Arbitrum
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  5. Avalanche
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  6. Binance Smart Chain
    • check gas settings and gas price
    • sign
    • check transaction on scan website

🎁 Send ERC20

  1. Ethereum mainnet
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  2. Polygon
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  3. Optimism
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  4. Arbitrum
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  5. Avalanche
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  6. Binance Smart Chain
    • check gas settings and gas price
    • sign
    • check transaction on scan website

💸 Internal swap

  1. Ethereum mainnet
    • check token list
    • sign token spend approval
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  2. Polygon
    • check token list
    • sign token spend approval
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  3. Optimism
    • check token list
    • sign token spend approval
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  4. Arbitrum
    • check token list
    • sign token spend approval
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  5. Avalanche
    • check token list
    • sign token spend approval
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  6. Binance Smart Chain
    • check token list
    • sign token spend approval
    • check gas settings and gas price
    • sign
    • check transaction on scan website

📡 dApps connections

🎭 Sign in with Ethereum

🐶 Default wallet

  1. Default wallet setting turned OFF
    • connect with dapp without MM available using Taho
    • connect with dapp with MM available using MM
  2. Default wallet setting turned ON
    • connect with dapp without MM available using Taho
    • connect with dapp with MM available using Taho

⚙️ Settings

  • check hide balance under $2 option
  • check bug reports - export logs
  • check connected dapp - confirm you are able to disconnect from a dapp

☀️ Abilities

  • check each filter option
  • delete ability
  • mark ability as completed

🌠 NFTs page

  1. NFTs page
    • browse NFTs
    • expand and collapse collection
    • check NFT preview
    • check Badges tab
  2. NFTs filters
    • check each sort type
    • disable account
    • disable collection

🦾 Flashbots

  1. Enable Flashbots in settings:
    • send/swap an asset & confirm trxn on Ethereum shows the Flashbots option with it auto-selected
    • confirm trxn is then sent through Flashbots
    • send/swap another asset deselect Flashbots option
    • confirm that trxn is not sent through Flashbots
  2. Check trxns on other networks
    • confirm Flashbots checkbox isn't shown at all
    • confirm trxn is not sent through Flashbots
  3. Disable Flashbots option in settings
    • send/swap an asset on Ethereum & confirm trxn shows without the Flashbots option
    • confirm trxn is not sent through Flashbots

@andreachapman
Copy link
Contributor

The only semi-concerning thing I saw was with the Abilities (as discussed in Discord). Otherwise, all tests are passing.

@Shadowfiend
Copy link
Contributor Author

Kk we are going to take the potential hit on the abilities front and look it up separately, and ship this release so we can unblock a few fixes for next week.

@Shadowfiend
Copy link
Contributor Author

(Going to take the above note from @andreachapman as an approving review and force the merge.)

@Shadowfiend Shadowfiend merged commit abb4d31 into main Sep 2, 2023
13 checks passed
@Shadowfiend Shadowfiend deleted the release-0.48.0 branch September 2, 2023 20:05
@Shadowfiend Shadowfiend mentioned this pull request Sep 7, 2023
Merged
Shadowfiend added a commit that referenced this pull request Sep 8, 2023
@Shadowfiend
v0.49.0 (#3625)
e72c0fd 
## Highlights
- Fixed an issue where valid private keys would not be accepted. These
always had one or more `0`s at the beginning.
- Fixed an issue where certain types of errors were causing sites not to
load correctly.

## What's Changed
* v0.48.0 by @Shadowfiend in
#3610
* Attempt to import private key to validate it by @jagodarybacka in
#3614
* Group private keys when categorizing by @Shadowfiend in
#3618
* Assert URL of the scan website opened for unverified assets by
@michalinacienciala in #3602
* Handle invalid responses on batch rpc providers by @hyphenized in
#3615
* Joint Privacy: Rework analytics service event management and add
signing tracking by @Shadowfiend in
#3623


**Full Changelog**:
v0.48.0...v0.49.0

Latest build:
[extension-builds-3625](https://github.com/tahowallet/extension/suites/15924368205/artifacts/909765830)
(as of Thu, 07 Sep 2023 20:56:50 GMT).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Shadowfiend @andreachapman