Add static subcape link to the wallet #3670
Conversation
| .subscape_link { | ||
| cursor: pointer; | ||
| position: absolute; | ||
| z-index: 998; // Above the UI, below the menu |
There was a problem hiding this comment.
Maybe we could set z-index as a CSS variable (not sure how reusable it'd be, up to you)
There was a problem hiding this comment.
I would love to but this is a bigger refactor because we have a lot of z-indexes to take care of, let's do it later
There was a problem hiding this comment.
Let's create an issue for it then (if it is not created already of course)
There was a problem hiding this comment.
Hadn't seen variables used for z-indices before, I like that!
Co-authored-by: Michał Paczyński <michal.paka@op.pl>
| type="button" | ||
| className={classNames("subscape_link", { visible: isVisible })} | ||
| onClick={() => { | ||
| window.open("https://app.taho.xyz/", "_blank")?.focus() |
There was a problem hiding this comment.
Generally, we should avoid passing the arrow function directly as a prop to improve performance, because the arrow function in prop creates a new function each time the component renders. In this case, it is a small issue, but in the future, it's good to create separate const openDapp = () => {} (also using useMemo) and only then pass it as a prop.
There was a problem hiding this comment.
I see but in this repo it is a common practice and I believe that if arrow function is assigned to the low-level DOM node (not other React component) the optimisation it provides is super small so we generally were not concerned about it in the past
There was a problem hiding this comment.
We can leave it as it is here, because it's small issue, but generally in the future we must pay special attention to this considering the general performance problems of the application.
There was a problem hiding this comment.
We should def do some digging. For the most part we've found that performance issues have come in places that aren't strictly related to rendering (in particular, they've come from the JSON serialization/deserialization that happens for state sync between background and foreground scripts). Could be that we're compounding that, too.
We've reduced a lot of that, but we still do a full JSON serialization of redux state to local storage every 50ms or so during busy times, which I'm guessing is still at the core of a lot of the pain here.
| onClick={() => { | ||
| window.open("https://app.taho.xyz/", "_blank")?.focus() | ||
| }} | ||
| onMouseEnter={() => setIsVisible(true)} |
There was a problem hiding this comment.
Also here we can create const showButton/hideButton.
| const [isVisible, setIsVisible] = useState(false) | ||
|
|
||
| return ( | ||
| <button |
There was a problem hiding this comment.
Based on the state isVisible we should return null or button because I don't see the reason to return the button when it's not needed.
There was a problem hiding this comment.
it is needed all the time, if isVisible = false then the button is tucked away but the icon is still visible
There was a problem hiding this comment.
I think this points to a tweak we can make to the naming. isVisible should probably be isCompact, isIconOnly, onlyShowIcon or something similar to indicate that we're not hiding the whole link.
There was a problem hiding this comment.
LGTM, we can merge it after changing the name of isFullyVisible to isIconOnly or showIcon which was suggested by @Shadowfiend.
## What's Changed * Check connecting to dapp on different network after disconnecting by @michalinacienciala in #3654 * v0.51.0 by @Shadowfiend in #3652 * Fix typos by @xiaolou86 in #3668 * Alchemic Logs: Small improvements for eth_getLogs by @Shadowfiend in #3664 * Fix getting currently connected dapp info by @jagodarybacka in #3671 * Add static subcape link to the wallet by @jagodarybacka in #3670 * Fix e2e tests by @michalinacienciala in #3651 * Add Alchemy endpoint for Arbitrum Sepolia by @jagodarybacka in #3665 * Do notify: Set up base NotificationService by @Shadowfiend in #3666 ## New Contributors * @xiaolou86 made their first contribution in #3668 **Full Changelog**: v0.51.0...v0.52.0 Latest build: [extension-builds-3678](https://github.com/tahowallet/extension/suites/18415208655/artifacts/1067210815) (as of Wed, 22 Nov 2023 14:53:11 GMT).
Resolves #3669
What
Subscape link in the wallet:
Button will be hidden later after the beta season will end (#3673)
Testing
Screen.Recording.2023-11-14.at.15.16.16.mov
Latest build: extension-builds-3670 (as of Sat, 18 Nov 2023 21:35:42 GMT).