Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #91
There are two main changes:
You can verify it by running
expected output:
The tests on master are currently broken (ref #89), with
test_std_dst
failing. With this change, that test now passes, but unfortunatelytest_std_dst2
fails. However, I am not sure thattest_std_dst2
is correctly written. It seems like that test expects the cron string to be specifying the UTC trigger times, but in reality the cron string is interpreted as the local timezone. I'm tempted to rewrite/delete that test. I would like someone else's opinion on that, though, as I'm not 100% sure.