This repository has been archived by the owner on May 3, 2024. It is now read-only.
Add bytecode benchmark #20
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: smtmfft <smtmfft@taikocha.in>
Signed-off-by: smtmfft <smtm@taiko.xzy>
github-actions
bot
added
crate.zkevm-circuits
crate.circuit-benchmarks
type.bench
labels
added 2 commits
September 20, 2022 08:02
smtmfft
force-pushed
the
add-benches
branch
from
dbff513
to
2376ae7
Compare
smtmfft
force-pushed
the
add-benches
branch
from
b2d67f6
to
781e358
Compare
Brechtpd
reviewed
Sep 20, 2022
added 2 commits
September 21, 2022 10:16
Signed-off-by: smtmfft <smtm@taiko.xzy>
Brechtpd
reviewed
Sep 21, 2022
Comment on lines
33
to
36
| let bytecodes_len: u32 = var("BTYECODES_LEN") | ||
| .unwrap_or_else(|_| "1".to_string()) | ||
| .parse() | ||
| .expect("Cannot parse BTYECODES_LEN env var as u32"); |
There was a problem hiding this comment.
Not sure I understand the purpose of this.
There was a problem hiding this comment.
bytecode_circuit absorbs bytecode array, i.e., 1 or N bytecodes. To make a full data table, we can either use 1 large bytecode or N small bytecode to fill up the 2^k rows. This variable is created for these 2 cases, although they actually makes little difference.
added 3 commits
September 23, 2022 04:08
Signed-off-by: smtmfft <smtm@taiko.xzy>
Signed-off-by: smtmfft <smtm@taiko.xzy>
Signed-off-by: smtmfft <smtm@taiko.xzy>
Brechtpd
reviewed
Sep 26, 2022
Brechtpd
reviewed
Sep 26, 2022
Brechtpd
reviewed
Sep 26, 2022
Comment on lines
121
to
128
| if bytecodes_num == 0 { | ||
| vec![] | ||
| } else { | ||
| assert!(bytecode_len >= 1); | ||
| (0..bytecodes_num * bytecode_len) | ||
| .collect::<Vec<usize>>() | ||
| .chunks(bytecode_len) | ||
| .map(|idx_range| { |
There was a problem hiding this comment.
Simple for loop makes ,more sense here? Because you do bytecodes_num * bytecode_len and then create chunks of bytecode_len, so may as well just use some loops?
There was a problem hiding this comment.
Yes, only diff is the value sequence, changed to for_each loop and make the fillup logic simpler.
added 6 commits
September 27, 2022 07:35
Signed-off-by: smtmfft <smtm@taiko.xzy>
Signed-off-by: smtmfft <smtm@taiko.xzy>
Signed-off-by: smtmfft <smtm@taiko.xzy>
Signed-off-by: smtmfft <smtm@taiko.xzy>
Signed-off-by: smtmfft <smtm@taiko.xzy>
Brechtpd
approved these changes
Sep 27, 2022
Signed-off-by: smtmfft <smtm@taiko.xzy>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To resolve privacy-scaling-explorations#666
Reuse BytecodeCircuitTester to avoid more dup code.