Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a --watch feature #2688

Closed
tusharmath opened this issue Aug 14, 2024 · 13 comments
Closed

Add a --watch feature #2688

tusharmath opened this issue Aug 14, 2024 · 13 comments
Labels
💎 Bounty state: inactive No current action needed/possible; issue fixed, out of scope, or superseded.

Comments

@tusharmath
Copy link
Contributor

tusharmath commented Aug 14, 2024

Use rs-notify library to identify if the source files have changed and restart the server when it does.

Example Usage

tailcall start ./jp.graphql --watch

Technical Requirements

  • Restart should happen automatically when the main config or any of the linked file changes.
  • There should be no leaks in restarts and should happen seamlessly.
  • Should not crash the server if there is a validation error.
@tusharmath
Copy link
Contributor Author

/bounty 50$

Copy link

algora-pbc bot commented Aug 14, 2024

## 💎 $50 bounty • Tailcall Inc.

### Steps to solve:
1. Start working: Comment /attempt #2688 with your implementation plan
2. Submit work: Create a pull request including /claim #2688 in the PR body to claim the bounty
3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

🙏 Thank you for contributing to tailcallhq/tailcall!
🧐 Checkout our guidelines before you get started.
💵 More about our bounty program.

Attempt Started (GMT+0) Solution
🔴 @neo773 Aug 14, 2024, 7:54:47 AM WIP
🔴 @harshtech123 Aug 14, 2024, 10:34:00 AM WIP
🔴 @akhilender-bongirwar Aug 14, 2024, 1:02:57 PM WIP
🔴 @onyedikachi-david Aug 14, 2024, 2:01:16 PM WIP
🟢 @beelchester Aug 14, 2024, 2:55:39 PM #2707

@harshtech123
Copy link

harshtech123 commented Aug 14, 2024

/attempt #2688

harshtech123 added a commit to harshtech123/infer_type_name.rs that referenced this issue Aug 14, 2024
@akhilender-bongirwar
Copy link

akhilender-bongirwar commented Aug 14, 2024

/attempt #2689

Copy link

algora-pbc bot commented Aug 14, 2024

Note

The user @harshtech123 is already attempting to complete issue #2688 and claim the bounty. We recommend checking in on @harshtech123's progress, and potentially collaborating, before starting a new solution.

@onyedikachi-david
Copy link

onyedikachi-david commented Aug 14, 2024

/attempt #2688

Algora profile Completed bounties Tech Active attempts Options
@onyedikachi-david    3 tailcallhq bounties
+ 2 bounties from 1 project
JavaScript, Shell
Cancel attempt

@beelchester
Copy link
Contributor

beelchester commented Aug 14, 2024

/attempt #2688

Algora profile Completed bounties Tech Active attempts Options
@beelchester 8 tailcallhq bounties
Rust, TypeScript,
CSS & more
Cancel attempt

Copy link

algora-pbc bot commented Aug 15, 2024

@harshtech123: Reminder that in 1 days the bounty will become up for grabs, so please submit a pull request before then 🙏

Copy link

algora-pbc bot commented Aug 15, 2024

@onyedikachi-david: Reminder that in 1 days the bounty will become up for grabs, so please submit a pull request before then 🙏

@bnchi
Copy link
Contributor

bnchi commented Aug 18, 2024

rs-notify doesn't work well with VIM or some other editors when watching for specific files : https://docs.rs/notify/latest/notify/#editor-behaviour

It's a bit tricky as well to watch for files that are linked in a @link directive because the src path is relative to the file they're defined in

@beelchester
Copy link
Contributor

rs-notify doesn't work well with VIM or some other editors when watching for specific files : https://docs.rs/notify/latest/notify/#editor-behaviour

Yes, true. It may trigger 2 or more data change events on a single file modification.
To fix this I have added a debounce delay in my PR (#2707), it ignores modification events for a specified time after the initial trigger to restart the server. It is working reliably well.

Copy link

Action required: Issue inactive for 30 days.
Status update or closure in 7 days.

@github-actions github-actions bot added the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Sep 29, 2024
Copy link

github-actions bot commented Oct 6, 2024

Issue closed after 7 days of inactivity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💎 Bounty state: inactive No current action needed/possible; issue fixed, out of scope, or superseded.
Projects
None yet
6 participants