Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create .tailcallrc.schema.json on init #1448

Merged
merged 1 commit into from
Mar 15, 2024
Merged

fix: create .tailcallrc.schema.json on init #1448

merged 1 commit into from
Mar 15, 2024

Conversation

neo773
Copy link
Contributor

@neo773 neo773 commented Mar 15, 2024

Summary:
Briefly describe the changes made in this PR.

Issue Reference(s):
Fixes #1446

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

/claim #1446

Summary by CodeRabbit

  • New Features
    • Introduced a feature to include and write a JSON file during the initialization process based on user confirmation.

Copy link
Contributor

coderabbitai bot commented Mar 15, 2024

Walkthrough

This change introduces a new constant JSON_FILE_NAME and modifies the init function to include a JSON file, specifically writing the .tailcallrc.schema.json file based on user confirmation. This addresses the need for the tailcall init command to generate a necessary JSON schema file, enhancing the tool's functionality and user experience.

Changes

File(s) Change Summary
src/cli/tc.rs Added JSON_FILE_NAME, updated init to include and write JSON file based on user confirmation

Assessment against linked issues

Objective Addressed Explanation
bug: tailcall init command should create .tailcallrc.schema.json file (#1446)

Poem

🐇 In the realm of code, a rabbit hopped,
Adding lines, where the progress stopped.
".tailcallrc.schema.json", now it writes,
A fix in the dark, bringing lights.
🌟 With every key, a new dawn,
For bugs and issues, now are gone.
In the code, a leap, a bound,
Where once was lost, now is found. 🌈

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@github-actions github-actions bot added the type: fix Iterations on existing features or infrastructure. label Mar 15, 2024
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 88.52%. Comparing base (78460e8) to head (0aca3d5).

Files Patch % Lines
src/cli/tc.rs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1448      +/-   ##
==========================================
- Coverage   88.55%   88.52%   -0.03%     
==========================================
  Files         129      129              
  Lines       13751    13755       +4     
==========================================
  Hits        12177    12177              
- Misses       1574     1578       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 3

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 78460e8 and 0aca3d5.
Files selected for processing (1)
  • src/cli/tc.rs (3 hunks)
Check Runs (1)
codecov/patch failure (4)
  • src/cli/tc.rs: 77-77: Added line #L77 was not covered by tests
  • src/cli/tc.rs: 80-80: Added line #L80 was not covered by tests
  • src/cli/tc.rs: 93-93: Added line #L93 was not covered by tests
  • src/cli/tc.rs: 97-97: Added line #L97 was not covered by tests
Additional comments: 1
src/cli/tc.rs (1)
  • 20-20: The addition of the JSON_FILE_NAME constant is a straightforward and necessary change to support the creation of the .tailcallrc.schema.json file. This aligns with the PR's objective to fix the issue where the tailcall init command did not generate this file.

src/cli/tc.rs Show resolved Hide resolved
src/cli/tc.rs Show resolved Hide resolved
src/cli/tc.rs Show resolved Hide resolved
@tusharmath tusharmath enabled auto-merge (squash) March 15, 2024 10:59
@tusharmath tusharmath changed the title fix: #1446 fix: create .tailcallrc.schema.json on init Mar 15, 2024
@tusharmath tusharmath merged commit 6fb1aa6 into tailcallhq:main Mar 15, 2024
25 of 28 checks passed
ssddOnTop pushed a commit that referenced this pull request Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🙋 Bounty claim type: fix Iterations on existing features or infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: tailcall init command should create .tailcallrc.schema.json file
2 participants