Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(2727): drop Result from Mustache::parse #2728

Merged
merged 7 commits into from
Aug 17, 2024

Conversation

ssddOnTop
Copy link
Member

Issue Reference(s):
Fixes #2727
/claim 2727

@github-actions github-actions bot added the type: chore Routine tasks like conversions, reorganization, and maintenance work. label Aug 17, 2024
@ssddOnTop ssddOnTop changed the title chore: drop Result from Mustache::parse chore(2727): drop Result from Mustache::parse Aug 17, 2024
@tusharmath tusharmath marked this pull request as ready for review August 17, 2024 12:43
@tusharmath tusharmath enabled auto-merge (squash) August 17, 2024 12:43
Copy link

codecov bot commented Aug 17, 2024

Codecov Report

Attention: Patch coverage is 98.05825% with 2 lines in your changes missing coverage. Please review.

Project coverage is 86.47%. Comparing base (1ff85a0) to head (a41398b).
Report is 1 commits behind head on main.

Files Patch % Lines
src/core/config/telemetry.rs 0.00% 1 Missing ⚠️
src/core/mustache/parse.rs 94.73% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2728      +/-   ##
==========================================
- Coverage   86.47%   86.47%   -0.01%     
==========================================
  Files         255      255              
  Lines       25019    25008      -11     
==========================================
- Hits        21636    21626      -10     
+ Misses       3383     3382       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tusharmath tusharmath marked this pull request as draft August 17, 2024 13:34
auto-merge was automatically disabled August 17, 2024 13:34

Pull request was converted to draft

@tusharmath
Copy link
Contributor

Build Failure @ssddOnTop

Moving to draft to reduce noise and improve CI efficiency. Once you are ready just mark it as "ready to review". Feel free to give a shoutout on the #contributors channel on Discord if you want immediate attention.

@ssddOnTop ssddOnTop marked this pull request as ready for review August 17, 2024 14:25
@ssddOnTop ssddOnTop merged commit 2726d35 into main Aug 17, 2024
35 of 36 checks passed
@ssddOnTop ssddOnTop deleted the chore/drop-result-mustache branch August 17, 2024 14:26
beelchester pushed a commit to beelchester/tailcall that referenced this pull request Aug 21, 2024
Co-authored-by: Tushar Mathur <tusharmath@gmail.com>
beelchester pushed a commit to beelchester/tailcall that referenced this pull request Aug 21, 2024
Co-authored-by: Tushar Mathur <tusharmath@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🙋 Bounty claim type: chore Routine tasks like conversions, reorganization, and maintenance work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

drop Result from Mustache::parse
2 participants