Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(grpc): handle union shared fields #2757

Merged
merged 11 commits into from
Aug 28, 2024
Merged

Conversation

meskill
Copy link
Contributor

@meskill meskill commented Aug 26, 2024

Summary:
Pr to address differences in async_graphql and jit engines related to selecting shared fields from union type.

I've checked other graphql implementations and it appeared that original test should not work actually based on spec. So this pr:

  • generates shared interface for oneOf for proto config generator
  • test now uses interface fragment to select shared fields
  • improve jit implementation for tests to handle interfaces on fragments

Issue Reference(s):
Fixes #... (Replace "..." with the issue number)

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly.
  • I have performed a self-review of my code.
  • PR follows the naming convention of <type>(<optional scope>): <title>

@github-actions github-actions bot added the type: fix Iterations on existing features or infrastructure. label Aug 26, 2024
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 98.85057% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.33%. Comparing base (aa669c4) to head (8a39bf6).
Report is 1 commits behind head on main.

Files Patch % Lines
src/core/ir/resolver_context_like.rs 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2757      +/-   ##
==========================================
+ Coverage   86.21%   86.33%   +0.11%     
==========================================
  Files         255      255              
  Lines       25105    25155      +50     
==========================================
+ Hits        21645    21717      +72     
+ Misses       3460     3438      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/core/jit/model.rs Outdated Show resolved Hide resolved
src/core/jit/model.rs Outdated Show resolved Hide resolved
@tusharmath tusharmath marked this pull request as draft August 27, 2024 13:48
@meskill meskill marked this pull request as ready for review August 28, 2024 08:49
@tusharmath tusharmath enabled auto-merge (squash) August 28, 2024 15:23
@tusharmath tusharmath merged commit 6caf179 into main Aug 28, 2024
31 checks passed
@tusharmath tusharmath deleted the fix/jit-union-shared-field branch August 28, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: fix Iterations on existing features or infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants